From: Ian Campbell <ijc@hellion.org.uk>
To: Heiko Stuebner <heiko@sntech.de>, Arnd Bergmann <arnd@arndb.de>,
Olof Johansson <olof@lixom.net>
Cc: linux-kernel@vger.kernel.org,
Brian Norris <briannorris@chromium.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: rockchip: Drop explicit "include/" prefix from #include
Date: Wed, 17 May 2017 02:13:42 +0100 [thread overview]
Message-ID: <1494983622.32636.5.camel@hellion.org.uk> (raw)
In-Reply-To: <3956756.APWK7IdRuP@phil>
On Sat, 2017-05-13 at 17:43 +0200, Heiko Stuebner wrote:
> Hi Ian,
>
> Am Samstag, 13. Mai 2017, 00:53:57 CEST schrieb Ian Campbell:
> > It not necessary and counter to how all the other files are done.
> >
> > It also happens to break the build in the split device tree repo
> > https://git.kernel.org/pub/scm/linux/kernel/git/devicetree/devicetr
> > ee-rebasing.git/
> >
> > Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
> > Cc: Brian Norris <briannorris@chromium.org>
> > Cc: Heiko Stuebner <heiko@sntech.de>
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: Mark Rutland <mark.rutland@arm.com>
> > Cc: Catalin Marinas <catalin.marinas@arm.com>
> > Cc: Will Deacon <will.deacon@arm.com>
> > Cc: linux-arm-kernel@lists.infradead.org
> > Cc: linux-rockchip@lists.infradead.org
> > Cc: linux-kernel@vger.kernel.org
>
> that glitch also breaks Olof's patch [0] fixing a depmod symlink
> recursion in that it creates
>
> ../arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts:47:57: fatal
> error: include/dt-bindings/input/linux-event-codes.h: File or
> directory not found
> #include <include/dt-bindings/input/linux-event-codes.h>
>
> with only Olof's patch applied. So I guess both patches should go
> together with this one in front, so to be on the safe side, if some
> else
> is going to apply both:
>
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Not sure who should/wil merge this, but it seems I neglected to Cc Arnd
and Olof so I'm doing so now.
Would be good to get this in soonish.
Ian
prev parent reply other threads:[~2017-05-17 1:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-12 23:53 [PATCH] arm64: dts: rockchip: Drop explicit "include/" prefix from #include Ian Campbell
2017-05-13 0:53 ` Brian Norris
2017-05-13 15:43 ` Heiko Stuebner
2017-05-17 1:13 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1494983622.32636.5.camel@hellion.org.uk \
--to=ijc@hellion.org.uk \
--cc=arnd@arndb.de \
--cc=briannorris@chromium.org \
--cc=catalin.marinas@arm.com \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox