From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753628AbdEREkK (ORCPT ); Thu, 18 May 2017 00:40:10 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:50795 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752572AbdEREkF (ORCPT ); Thu, 18 May 2017 00:40:05 -0400 Subject: Re: [PATCH] scsi: remove useless variable assignment From: James Bottomley To: "Gustavo A. R. Silva" , "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 17 May 2017 21:39:58 -0700 In-Reply-To: <20170518003043.GA5664@embeddedgus> References: <20170518003043.GA5664@embeddedgus> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17051804-0020-0000-0000-00000BF6EC86 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007080; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000212; SDB=6.00862057; UDB=6.00427630; IPR=6.00641715; BA=6.00005356; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00015498; XFM=3.00000015; UTC=2017-05-18 04:40:04 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17051804-0021-0000-0000-00005C5F6F1F Message-Id: <1495082398.2840.14.camel@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-05-18_01:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1705180032 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-05-17 at 19:30 -0500, Gustavo A. R. Silva wrote: > Remove this assignment once the value stored in variable _k_ is > overwritten after a few lines. > > Addresses-Coverity-ID: 1226927 > Signed-off-by: Gustavo A. R. Silva > --- > drivers/scsi/qlogicfas408.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/scsi/qlogicfas408.c > b/drivers/scsi/qlogicfas408.c > index c3a9151..269440a 100644 > --- a/drivers/scsi/qlogicfas408.c > +++ b/drivers/scsi/qlogicfas408.c > @@ -329,7 +329,6 @@ static unsigned int ql_pcmd(struct scsi_cmnd > *cmd) > */ > if ((k = ql_wai(priv))) > return (k << 16); > - k = inb(qbase + 5); /* should be 0x10, bus > service */ That doesn't look right to me. inb() is a statement which has an effect on the I/O device regardless of whether the returned value is used or discarded. In this case I think it's being used to clear pending interrupts, so removing it will likely cause a phase error. James