From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755592AbdERKI5 (ORCPT ); Thu, 18 May 2017 06:08:57 -0400 Received: from mail-cys01nam02on0085.outbound.protection.outlook.com ([104.47.37.85]:20664 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755576AbdERKIv (ORCPT ); Thu, 18 May 2017 06:08:51 -0400 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=nxp.com; Message-ID: <1495102114.26925.20.camel@nxp.com> Subject: Re: [PATCH 1/1] spi: imx: fix issue when tx_buf or rx_buf is NULL From: Leonard Crestez To: , CC: , Date: Thu, 18 May 2017 13:08:34 +0300 In-Reply-To: <1495101672-3384-1-git-send-email-jiada_wang@mentor.com> References: <1495101672-3384-1-git-send-email-jiada_wang@mentor.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu3.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131395757173096343;(91ab9b29-cfa4-454e-5278-08d120cd25b8);() X-Forefront-Antispam-Report: CIP:192.88.168.50;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(336005)(39400400002)(39410400002)(39450400003)(39380400002)(39860400002)(39840400002)(39850400002)(2980300002)(1109001)(1110001)(339900001)(377424004)(199003)(24454002)(189002)(9170700003)(105606002)(229853002)(189998001)(38730400002)(50466002)(2950100002)(305945005)(53936002)(106466001)(85426001)(103116003)(54906002)(6246003)(50986999)(86362001)(76176999)(104016004)(5660300001)(8936002)(50226002)(2906002)(33646002)(498600001)(23676002)(8676002)(77096006)(81166006)(5820100001)(356003)(230700001)(36756003)(4326008)(47776003)(99106002);DIR:OUT;SFP:1101;SCL:1;SRVR:BY1PR0301MB0901;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;MLV:ovrnspm;A:1;MX:1;PTR:InfoDomainNonexistent;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD015;1:WINPnY3jeENSEqeibarHmNkprLk5aL0r7/rrEX9vDZSLc+NGw8yW5gpBI55WqP7tpDc/zWavrx6Ntk0IqIzRvLHZZTEyV+UVsBFpeobAItjyliYxp2AA4FYvNYfc+3OSX7Hs5cRmjZ/91dZjDsDttyAhiC3QyRhn50ILlAgoFEWbTH0UBo3412XZ218wjbfDUtLESYvbwr7e4IZPpoF9dAUyy2ZWXzd3YGN9Klh+8RwvCLwdlVCFu+gVS21Qvi1d7mQ4luaSKgC1dhSmFfr/w3WlZEISboNxSmSeCyqqQr+mO/FjW0TjtoNVSpecUjTC2PKAF6mqBSpJU+r8IMFPOkoSejaLdZ6m8rGPx41RaFG0tOcwvQqtOMxAf203HgouLcMjN6sBhWX7cM2J2lFE+P4wKrNf7ZsiF1WSWoFE7HjivMRniZcXK4gl5DUL5fo9wpRUnb2J4up4twdStVoQ+08YfGoy3ULWZrZnTnGBKp+LqER7vWo6s8G69R3zkrZCZNr9VY3V5dAzLrJWVWFRdo9hMvvLT0CH1VP9htGmxYg9BAK3HKTS/GKn2BwVGmWReBB2QXtbWibfmhjYQfOE6WnDyj92R7/x2fdTZ6T2CwT32H3VncYvE6NE85G1Z+33 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c3677180-9fc7-4a91-bf97-08d49dd5d9c2 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131430075)(201703131517081);SRVR:BY1PR0301MB0901; X-Microsoft-Exchange-Diagnostics: 1;BY1PR0301MB0901;3:auxrdeH4JmzmGDPcKragLvQzwqud1ogBAwvRtizC78SVrzAtdbMbcRbG4vPfXOeJQgv3MkfDUK0mJ+jbqLhWM28LtV/cIbdNv3iTRuhFf+fUnYFyFwg2m862GgD/0MolL321GG287iGngOBHQioyDT2wg/EpYaw8MX69k5CKovU+iHwRnZLkJXI4O0BlSzWgQm1s5I33EjUjAJXge6qoX3CvJCNy3dU0MAy5NKvoDCoxaMd/tr2X7rH8rqcPNv2xRuA+y3SLavJPdVf3R08RgA1l1DwTXXdVEDHMAM7wts8syOLk4Z29LJPczxQ1oWpWI7D3Lw0eDJ3P5Ou1IuBQgzULtUUnPLANgTEWhNWyEsehonSLJN6FgqT8FsqsiR/TuY41+XwPxExjlGzzymq9W9MQpWs50wNneVuDaj6qNF+DFWoJmq6Fos4rsAD6odZB;25:iA4tvu95R8YkHM3wetHEjyicI0U4EfwtwXR525Ld5sqgdUBOu1QzLAMagUenPv/GdCXrBy2uxPNcDbWHhTOpbkzppWRCdyepyPU7dCIXSwh2i/FQe91yfz191A3jU3UTVOd7Siiki7y6w0hj4VL4y/AleLEYOEbbvcBEDFnlqE3fwOMj0XI0VD6Pt8Xn2KyR0FFzHuml/fwi5W/awuwGwULn7omNF+b1zsSQnGRABchkvqjswBPrKo5ZLoGN20IGdO2C17/JjOpGNf7i9Fd0Q6pr2JXZIcbzKH2xnErjbQV2bm1tEZD6xZnVQoXHdn5pCIdFwAI6z4w+NBJcsJha5TcOa0NmuUO6gMe97z0bSXJ37HuUuAi9YiEl5IAJchYtBPqEjSAv5Y0utxnHIjjczoKCmsNsJD5/8veFfSA30bcIJ+1arINKuwju0E1JGZFkef986glr/ymTlg7UTcs0aQ== X-Microsoft-Exchange-Diagnostics: 1;BY1PR0301MB0901;31:B+WQ9zGNc9rW3b1w9EqCtiJHA3s85hdk9FKREwwC5y67q3XLDEuC4/TBV69SXn+Q/jKZq6xhFMTBZlHd6ZmHoaJWpUkgdW+S0hs0rSGmMRimxn2WW53awFjim33viNt+qmTMpeV/dSS0JQ9Qrjjusv6vxFnWLZS78YquUxYd8ix6LoH2xBipf0gaAy/rcf+fMPju1davG2CA/auT+Lph0+wJDLKrbjDja1VKO+PAQ2V3d8D9t7WWZwgsp9ujguR/ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6095135)(601004)(2401047)(5005006)(13015025)(13017025)(13018025)(13024025)(13023025)(8121501046)(3002001)(93006095)(93001095)(10201501046)(6055026)(6096035)(20161123556025)(20161123563025)(20161123561025)(20161123559100)(201703131430075)(201703131441075)(201703131448075)(201703131433075)(201703161259150)(20161123565025);SRVR:BY1PR0301MB0901;BCL:0;PCL:0;RULEID:(400006);SRVR:BY1PR0301MB0901; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTFQUjAzMDFNQjA5MDE7NDpsTjFBeEsvQTRleXNoY3VnODhJbi9yL0Vl?= =?utf-8?B?SlUwcXhCaWlNY291SUlYTEZ5eHZXbGpPZnd5Z01WTFpnb3NnaVhQNERoenpl?= =?utf-8?B?WUJlcERPRkd0SWxzRisvaXZZbklrM20zS3lieHRsem85eWVjKzdhbU5hK1RO?= =?utf-8?B?QTFGUkFHaE52UmlVazQ5NVgrRGtod2V6NCtTSmk1TGNKZnVhQ0RpemlXMWlZ?= =?utf-8?B?cDJUWmQ3UnpRNFM2QksvajlOelpWTWR6MnlVR1JOS0pCWWRJQVhMQVpueHpE?= =?utf-8?B?eVE4NFlnRWFJVjNGS2xjS3dLZkRxd05oWTZHL2V2amFSbTJqUmE3TjR5UW55?= =?utf-8?B?clYvYkx1aW1sMWtBeGtxWlFPZzY5TXRPNEp6djczdzZQQXRPRDVDbmc0WmQy?= =?utf-8?B?U1ZlTXVDM3FZWHVuSVV2TExtUlhpaTBvOEk2cWoyT245am1kR2ZvRnR4R3Bn?= =?utf-8?B?eWdPdDc5NkpHUTI3R1VCditvb2pZRy8xRFRPd0ZnYlNLcWlNWWhuWVl0SDNs?= =?utf-8?B?VWQzOTQ2SWI2eVQ0M1RnUGp2Q0FOdXhmdFN6dTlwSkFRVitBUnFqcFBnU0RU?= =?utf-8?B?S25PRnZCcG1aby9ad3RHTW1HSHlJSjd6cmNEMnpraTBWb2VGcmpFSkNwbEU4?= =?utf-8?B?RHNid0xXWitXM0JUcE1raWVBYWFnMURObDFxckpTTWg0RVQyQlNpTk9XVUd0?= =?utf-8?B?ZVB1SXBwSmIwY2luOUo3dHExV1FvaG1ySGdhaW1zRHd3YmwvSnZyQnlqNUpU?= =?utf-8?B?ZUNwRkhrMGhDVDN1RXRId0JwTmVkOFFNcjlhUUNyWE8ycUo4QVFsTmFqYWdq?= =?utf-8?B?SXdvVXU3M1hxa0RMRkVWb0xXMG1RNGFDUDl4aHA2K0VBME5TWTRKbTR4KzlO?= =?utf-8?B?WGhWMldlbitIbmJnV3FFNnpLa25kOUhoRDdQRi9vMG9DVzBuY0hOc3VPZ3NZ?= =?utf-8?B?M0N1SGg2aWpqVElZNnBlaU16TW9oRHdmN2cxTVArMmYzNkRINFA5eTFGa2tU?= =?utf-8?B?QWNkNEZIdmYvbm92dXVBUCs0cUFmNjkvWUp1b2ZYUTBRVXFCOU84QWUzNjhG?= =?utf-8?B?Y2V5eklBS1Z2TnJCOFIxL2JUeFBHQVAwMkRXRUt2dFhDbmxkSFJXbHVaL3B0?= =?utf-8?B?UllMNnNQdUVvSVpKNm5IUXlGSVlmYkVkOGMxUXBzL2luaDhLOHlNV05Dbm1u?= =?utf-8?B?U3RvWVhXTnVRVitRT2JsWnpITzgyaEtNVk9kMjgrVnl1QXlNaTlPYkVQcU5Q?= =?utf-8?B?UU1qdEd0WC8wWk8wN0xxeEV3VjZqVk1UckN6RU9HV25lbU42d1NLMURPQUpZ?= =?utf-8?B?SzJPcGJYZnVRdHZRPT0=?= X-Forefront-PRVS: 0311124FA9 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTFQUjAzMDFNQjA5MDE7MjM6VDhDZkNYNmgvVVBJQm9WRE1hTFVFc1Br?= =?utf-8?B?eDZxdUZPc1ZhaDlQRlhlV3pIQWpNRXNkVHkzTDdHV3gvWHFhMmIvK2tDSmxW?= =?utf-8?B?emZGMmdDS2d5TjFhalEwSkZBZ285eWcySTlPQ1JEd3Q1My95dHYrV1NPcU1H?= =?utf-8?B?bVNXZkdZUUNTOXlCdXdHUmdvZHRRcFpCTlNmcmVPOEtXSnYwQVNNMnFuZktq?= =?utf-8?B?dlJLS2RkVnVPVmN6anpZVU5YNnJsUi9Gbm9yRXJta29QUmNCR3c4RTczRUFl?= =?utf-8?B?ZTFOU1hXaVJRditpYlZKRVVYcy91OUFsNkFjU1E5VXZDOGxMa25qbEsrTVo0?= =?utf-8?B?bUJ1ME5OcDFyVjRrR0NIMWxzc1VHVXNGNHR4aUxPbUtnM3ZiNVlncFlqTnZh?= =?utf-8?B?ditwNkVYTG81MktoL2VuZThDdE1Iek1XUmVvdjNxL2VQU1o5bGlJaFVFWmo4?= =?utf-8?B?ZjF1b1V6VjhaT0xadEVDYThEb3haaWN6dFZKc2lvdVhxOVBsWkZTVnpsMUg5?= =?utf-8?B?UU1UQW9KLzdBZW5NQS9QM0RmYWdSMEs2R3NLL3VMUFRoeFNhOVBPcEF5UnVV?= =?utf-8?B?UHJDTlVFTVFvZGp4QkZvMWlxenV2dHNEZjg4dXY2UzZKeVlHQlhyNGNZKytv?= =?utf-8?B?bEdkaVdKZWxHNTlNYnR6QVN5WitseEUzaklvWFdaVTQ1cU9wYzJsTm02aC9S?= =?utf-8?B?S2tUR3RUM09XdzZNajhFbWlqcTZxQjdvdi85TW04dGZSUDZTdDNWcFNueU9U?= =?utf-8?B?WG5ON2Zkc3ZpRlZxWGl2OTR5WHlEVkt3YmRpeDVsQm40RlN3RWJKOWc4aW5a?= =?utf-8?B?OU9uT0R2a0gzU0RvVDF1VDhUWmtpb2hUZWdhQWxOUllseCtzaXlDb21MUXdR?= =?utf-8?B?Vlc0cDlOZXVocEp6RFVjdllwTmtLeXFrL2pya0VBUTNLZXlXUC9RNVFGTzRl?= =?utf-8?B?Yjh6UGh1NFZvSDlXcmlMVGFqK2ROZjc2TnRjelVmdWF1NU9RdTBvdFVQWmlw?= =?utf-8?B?UFUrWmwrNytTZ0d4bUp5eFBlSkxsOVc0NGJVSk5NMzhGM0tPcXNDSXIwbmRz?= =?utf-8?B?bXROZ0ZHcHBkN2t1KzNLKytBKzhvb01aSnNkczBnbHN0YTJ5azQ1NmlBK1Bh?= =?utf-8?B?ZDl3SFVBTDVtM0JQMzU2RmcybjlUZ1l2Z3h5V1pYczNZMU5zSG9aWjBML0F3?= =?utf-8?B?NzFlemZ1VSs0WmJQZDhSeHpLVXJRSjNTSFQ0SGY4dmNWMUJQZEhnY2lJOVpE?= =?utf-8?B?UmZTeHdrSEp5dUVQNldaazBSeDd2elN0a1BsQTVTbE1QSElXemJxdWdrczhU?= =?utf-8?B?QzgvSmgwUFlZVkQ2c1B6Q1RpeTIzeWNhamp2OGtRWUREVUU3bXM2dE5zVmlz?= =?utf-8?B?d3VZYy9UcGwrYUprclU0RDFWT2F0Zi9Md0dHc1QrZFpWNUkrMEN4OHBsalF5?= =?utf-8?B?YmFrTm02ZDR1Q3NndDQ1eWpkSWMweGZVRlZyOVhoTWJpU0dGSTk5YzBTeHZI?= =?utf-8?B?cWpuZDRJSXVUUUgyU2NyVWdYM3ZSczVzYlNKKzFrUDQzSXg4QzJCQyt2Y2hV?= =?utf-8?B?dVBJdDJTa0lnN0ErVWR0WFpHQ1lJcWUwK2h4Mmg0R0xSV3RWUWh5TnQ4bHVw?= =?utf-8?B?WDRjKzVrTUFJMGFmcDUwT3BlSmRVd1BJVTQ5RldGUVM2OTBxTDlTeFJUR09G?= =?utf-8?B?eStYSU1zN3I1a05GZzlEOHUzMVlML3RwMG1VZS9jTmE1Y3BVK01BalQwOERs?= =?utf-8?B?elRHWkh1Q2V5elhoS2UvNkZRPT0=?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR0301MB0901;6:kgPI3BlUe3DP9jfMMvNbVqrKLYPY7ZplRrwSt2T8cApEIKs45LHi1eVI12j+iphbJxRo86NZrPM1XOJYr35gA72j4uBrOn8YwYHDPg8eiuFEfuthCT4NuW8YqjwYXvnkePStK3O9B8CosHHDthtvxKMkbpicHUVafVcAs5CKUoTGbxy8iHDm5oo+mn//qUGR0uualREiHbeYZBLlG/c8bePiQBA7FP5xc2g9tP41XMqU21Q3ttkKDRAf7SCaQZZ1S0pEgYPMYW3WJcpfYGRjIXiXtjLAB4wRRmWWvX/2pBiaZnnzMLrPgGzJ4PF/dMuLkyz1brgfsFlHAkb+86/FbygZ9NyPuiImAeWGe3sjAlY8x/SBpMNOksYebBd+DW2IzJ/+/HmTcqTx0n5ltNkp4rBsuUT1LOW49kc26YxITogo9Xkio5CCqLAI5qnWSUwxPGHSnURfevVScq0B+y2Wto5AXw0uNqKcfZssoh5RAFe3GjEoqkIxSGAF5VbG7Sj4gWQyYiZKp8f6P1laMSu2SA==;5:xympYGLj2oTYRzoov7GXt22AvoykIyNR+5z832JbZPo7dv7u5msdPfpoUM/MA3ZlM9XT+pd/K9aFxDuVS6d/xPRyP7Nof1A02gSmHnGz5LnNZ1Rs2G3OAVfyO0WhSBjFIXPKxVlPUAcg8SnxNv5+tLj2TSczBT1Qb/BXn+r1Y4oyySvNJI0Hq+jcrzUGVLu2;24:nP6Cs1HrPjLHtSUIIvU2XOwS9lNvNxUh4iwTYUJtaEspbvxlJDZnVcSm2UbouYeYfJsAwPGhTVP2/jpQMN194Zab7TfssfGSxMZ5n4PynLs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BY1PR0301MB0901;7:jJGkTfb8baY2fO3pdpVNmsAfeDvXEYAaF8b/tGNpYtiMCFXOt3qOrCNOuvNAYYFl4I/BNp5UA4SFDAhRWBHhtqZVCPVAaj8st+u12UWOhcotV36nTZwFJatbWeH0xQlJC7EQkmKLunWiuqbCXl7dRTgsopBC79fPupGj5OmYwm1B1PuzPBertfgUQg9ikOsEXPovWjdQ0O2uUbiYu0Jwznq41lFFmF6YnecLbpA57IPxo+wGIzl/tz5WSexbfAlD7j/eRCAMl5kggR5XWa55i8+41pefwQesS64o28Le0YC8ubxSfZsrEsCdoCuTYlo+/+/1uSo4X0aEruPWHLaO1A== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2017 10:08:36.9196 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0301MB0901 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-05-18 at 03:01 -0700, jiada_wang@mentor.com wrote: > From: Jiada Wang > > In case either transfer->tx_buf or transfer->rx_buf is NULL, > manipulation of buffer in spi_imx_u32_swap_u[8|16]() will cause > NULL pointer dereference crash. > > Add buffer check at very beginning of spi_imx_u32_swap_u[8|16](), > to avoid such crash. > > Signed-off-by: Jiada Wang > Reported-by: Leonard Crestez Tested-by: Leonard Crestez