From: Gerd Hoffmann <kraxel@redhat.com>
To: Xiaoguang Chen <xiaoguang.chen@intel.com>
Cc: alex.williamson@redhat.com, intel-gfx@lists.freedesktop.org,
linux-kernel@vger.kernel.org, zhenyuw@linux.intel.com,
zhiyuan.lv@intel.com, intel-gvt-dev@lists.freedesktop.org,
zhi.a.wang@intel.com, kevin.tian@intel.com
Subject: Re: [PATCH v2 4/5] drm/i915/gvt: Dmabuf support for GVT-g
Date: Fri, 19 May 2017 13:28:55 +0200 [thread overview]
Message-ID: <1495193335.627.66.camel@redhat.com> (raw)
In-Reply-To: <1495101005-16045-5-git-send-email-xiaoguang.chen@intel.com>
> +/**
> + * Ioctl to query plane info or create dma-buf
> + */
> +#define INTEL_VGPU_QUERY_DMABUF 0
> +#define INTEL_VGPU_GENERATE_DMABUF 1
This should use _IO* #defines.
> +struct intel_vgpu_dmabuf {
> + __u32 plane_id;
> + /* out */
> + __u32 fd;
> + __u32 drm_format;
> + __u32 width;
> + __u32 height;
> + __u32 stride;
> + __u32 start;
> + __u32 x_pos;
> + __u32 y_pos;
> + __u32 size;
> + __u32 tiled;
I'd suggest to drop tiled, and add drm_format_mod (for
fourcc_mod_code()) instead.
You can also move intel_vgpu_plane_info to this place and just use it as
sub-struct for intel_vgpu_dmabuf.
cheers,
Gerd
next prev parent reply other threads:[~2017-05-19 11:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 9:50 [PATCH v2 0/5] drm/i915/gvt: Dma-buf support for GVT-g Xiaoguang Chen
2017-05-18 9:50 ` [PATCH v2 1/5] drm/i915/gvt: Extend the GVT-g architecture to support vfio device region Xiaoguang Chen
2017-05-18 9:50 ` [PATCH v2 2/5] drm/i915/gvt: OpRegion support for GVT-g Xiaoguang Chen
2017-05-18 15:43 ` He, Min
2017-05-19 2:20 ` Chen, Xiaoguang
2017-05-22 2:28 ` He, Min
2017-05-18 9:50 ` [PATCH v2 3/5] drm/i915/gvt: Frame buffer decoder " Xiaoguang Chen
2017-05-18 9:50 ` [PATCH v2 4/5] drm/i915/gvt: Dmabuf " Xiaoguang Chen
2017-05-18 10:27 ` Chris Wilson
2017-05-19 11:28 ` Gerd Hoffmann [this message]
2017-05-18 9:50 ` [PATCH v2 5/5] drm/i915/gvt: Adding interface so user space can get the dma-buf Xiaoguang Chen
2017-05-19 16:33 ` Alex Williamson
2017-05-22 2:00 ` Chen, Xiaoguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495193335.627.66.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xiaoguang.chen@intel.com \
--cc=zhenyuw@linux.intel.com \
--cc=zhi.a.wang@intel.com \
--cc=zhiyuan.lv@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox