linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ankit Kumar <ankit@linux.vnet.ibm.com>
To: keescook@chromium.org, anton@enomsg.org, ccross@android.com,
	tony.luck@intel.com
Cc: linux-kernel@vger.kernel.org, mahesh@linux.vnet.ibm.com,
	hbathini@linux.vnet.ibm.com, hegdevasant@linux.vnet.ibm.com,
	ankit@linux.vnet.ibm.com
Subject: [PATCH 2/2] Save current timestamp part of dmesg while writing oops message to pstore
Date: Mon, 22 May 2017 15:50:37 +0530	[thread overview]
Message-ID: <1495448437-15398-2-git-send-email-ankit@linux.vnet.ibm.com> (raw)
In-Reply-To: <1495448437-15398-1-git-send-email-ankit@linux.vnet.ibm.com>

Currently on panic or Oops, kernel saves the last few bytes from dmesg
buffer to nvram. Usually kdump does capture kernel memory and provide
dmesg logs as well. But in some cases where kdump fails to capture
vmcore, the dmesg buffer stored in nvram/pstore turns out to be very
helpful in analyzing root cause.

Present code creates pstore dump file(/sys/fs/pstore/dmesg-***) based on
timestamp(retrieved from header). Current pstore code creates dump file
(/sys/fs/pstore/dmesg-***) with that timestamp. Dump file can be analyzed
based on file creation time and we can make out whether dump file has latest
data or not.

But when we transfer pstore dump file(/sys/fs/pstore/dmesg-***) to other
machine or collect file using some utilities(sosreport/supportconfig) then file
timestamp gets changed and hence by looking at device file (dmesg-***) we won't
be able to identify whether dump has latest data or not.

Above issue can be fixed if we also have timestamp(dump creation time) as
initial few bytes while capturing dmesg buffer to pstore dump file
(/sys/fs/pstore/dmesg-***).


This patch enhances pstore write code to also write timestamp as part of data.

Here is sample log of dump file:(/sys/fs/pstore/dmesg-***)
Oops#1 Part1 [timestamp:1494939359.590463]


Above timestamp can be converted to current zone using date command.
 #date -d @1494939359.590463
 # Tue May 16 18:25:59 IST 2017

Signed-off-by: Ankit Kumar <ankit@linux.vnet.ibm.com>
---
 fs/pstore/platform.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c
index 4fedf83..f65000e 100644
--- a/fs/pstore/platform.c
+++ b/fs/pstore/platform.c
@@ -501,6 +501,7 @@ static void pstore_dump(struct kmsg_dumper *dumper,
 	unsigned long	flags = 0;
 	int		is_locked;
 	int		ret;
+	struct timespec timestamp;
 
 	why = get_reason_str(reason);
 
@@ -540,9 +541,11 @@ static void pstore_dump(struct kmsg_dumper *dumper,
 			dst_size = psinfo->bufsize;
 		}
 
+		pstore_get_timestamp(&timestamp);
 		/* Write dump header. */
-		header_size = snprintf(dst, dst_size, "%s#%d Part%u\n", why,
-				 oopscount, part);
+		header_size = snprintf(dst, dst_size, "%s#%d Part%u [timestamp:%lu.%lu]\n",
+				why, oopscount, part, (long)timestamp.tv_sec,
+				(long)(timestamp.tv_nsec / 1000));
 		dst_size -= header_size;
 
 		/* Write dump contents. */
-- 
2.7.4

  reply	other threads:[~2017-05-22 10:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-22 10:20 [PATCH 1/2]pstore: Move timestamp collection code to common pstore place Ankit Kumar
2017-05-22 10:20 ` Ankit Kumar [this message]
2017-05-22 23:51   ` [PATCH 2/2] Save current timestamp part of dmesg while writing oops message to pstore Kees Cook
2017-05-23  8:49     ` Ankit Kumar
2017-08-07  5:19       ` Ankit Kumar
2017-05-22 23:37 ` [PATCH 1/2]pstore: Move timestamp collection code to common pstore place Kees Cook
2017-05-23  8:12   ` Ankit Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1495448437-15398-2-git-send-email-ankit@linux.vnet.ibm.com \
    --to=ankit@linux.vnet.ibm.com \
    --cc=anton@enomsg.org \
    --cc=ccross@android.com \
    --cc=hbathini@linux.vnet.ibm.com \
    --cc=hegdevasant@linux.vnet.ibm.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mahesh@linux.vnet.ibm.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).