From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758657AbdEVKdT (ORCPT ); Mon, 22 May 2017 06:33:19 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:35120 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752735AbdEVKdQ (ORCPT ); Mon, 22 May 2017 06:33:16 -0400 From: Arvind Yadav To: vireshk@kernel.org, andriy.shevchenko@linux.intel.com, dan.j.williams@intel.com, vinod.koul@intel.com Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1] dmaengine: DW DMAC: Handle return value of clk_prepare_enable Date: Mon, 22 May 2017 16:01:48 +0530 Message-Id: <1495449108-31532-1-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org clk_prepare_enable() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/dma/dw/platform.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/dma/dw/platform.c b/drivers/dma/dw/platform.c index c639c60..bc31fe8 100644 --- a/drivers/dma/dw/platform.c +++ b/drivers/dma/dw/platform.c @@ -306,8 +306,12 @@ static int dw_resume_early(struct device *dev) { struct platform_device *pdev = to_platform_device(dev); struct dw_dma_chip *chip = platform_get_drvdata(pdev); + int ret; + + ret = clk_prepare_enable(chip->clk); + if (ret) + return ret; - clk_prepare_enable(chip->clk); return dw_dma_enable(chip); } -- 1.9.1