From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933369AbdEVNHy (ORCPT ); Mon, 22 May 2017 09:07:54 -0400 Received: from smtprelay0105.hostedemail.com ([216.40.44.105]:55895 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751312AbdEVNHr (ORCPT ); Mon, 22 May 2017 09:07:47 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3867:3872:4321:5007:10004:10400:10848:11026:11232:11473:11657:11658:11783:11914:12043:12296:12740:12895:13069:13311:13357:13439:13894:14659:14721:21080:21433:21627:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: roof95_43a96ea4a363d X-Filterd-Recvd-Size: 2152 Message-ID: <1495458463.2093.17.camel@perches.com> Subject: Re: [PATCH v2 1/4] net-next: stmmac: Convert new_state to bool From: Joe Perches To: Corentin Labbe , peppe.cavallaro@st.com, alexandre.torgue@st.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 22 May 2017 06:07:43 -0700 In-Reply-To: <20170522123347.5295-2-clabbe.montjoie@gmail.com> References: <20170522123347.5295-1-clabbe.montjoie@gmail.com> <20170522123347.5295-2-clabbe.montjoie@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2017-05-22 at 14:33 +0200, Corentin Labbe wrote: > This patch convert new_state from int to bool since it store only 1 or 0 [] > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c [] > @@ -849,11 +849,11 @@ static void stmmac_adjust_link(struct net_device *dev) > writel(ctrl, priv->ioaddr + MAC_CTRL_REG); > > if (!priv->oldlink) { > - new_state = 1; > + new_state = true; > priv->oldlink = 1; > } > } else if (priv->oldlink) { > - new_state = 1; > + new_state = true; > priv->oldlink = 0; > priv->speed = SPEED_UNKNOWN; > priv->oldduplex = DUPLEX_UNKNOWN; It seems oldlink could be bool as well. drivers/net/ethernet/stmicro/stmmac/stmmac.h:   int oldlink; drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:              if (!priv->oldlink) { drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:                      priv->oldlink = 1; drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:      } else if (priv->oldlink) { drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:              priv->oldlink = 0; drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:      priv->oldlink = 0; drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:      priv->oldlink = 0;