Re: [PATCH v2 0/3] Cleanup evergreen/si IRQ handling code

Christian König
2017-05-20T11:39:51Z

Am 20.05.2017 um 01:48 schrieb Lyude:
> This is the first part of me going through and cleaning up the IRQ handling
> code for radeon, since after taking a look at it the other day while trying to
> debug something I realized basically all of the code was copy pasted
> everywhere, and quite difficult to actually read through.
>
> Will come up with something for r600 and cik once I've got the chipsets on hand
> to test with.
>
> Lyude (3):
> drm/radeon: Cleanup display interrupt handling for evergreen, si
> drm/radeon: Cleanup HDMI audio interrupt handling for evergreen
> drm/radeon: Cleanup pageflipping IRQ handling for evergreen, si

I don't have time to do a line by line review, but what I saw looked
very good to me.

So the whole seres is Acked-by: Christian König <christian.koenig@amd.com>.

BTW: You don't want to take a look at the other hw generations as well?

Regards,
Christian.

>
> drivers/gpu/drm/radeon/evergreen.c | 943 ++++++--------------------------
> drivers/gpu/drm/radeon/radeon.h | 27 +-
> drivers/gpu/drm/radeon/radeon_irq_kms.c | 35 ++
> drivers/gpu/drm/radeon/si.c | 655 +++++-----------------
> 4 files changed, 344 insertions(+), 1316 deletions(-)
>