From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934866AbdEVSVK (ORCPT ); Mon, 22 May 2017 14:21:10 -0400 Received: from mga02.intel.com ([134.134.136.20]:59653 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933122AbdEVSVH (ORCPT ); Mon, 22 May 2017 14:21:07 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,378,1491289200"; d="scan'208";a="860066211" Message-ID: <1495477252.6967.64.camel@linux.intel.com> Subject: Re: [PATCH v1] dmaengine: DW DMAC: Handle return value of clk_prepare_enable From: Andy Shevchenko To: Arvind Yadav , vireshk@kernel.org, dan.j.williams@intel.com, vinod.koul@intel.com Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 22 May 2017 21:20:52 +0300 In-Reply-To: <1495449108-31532-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1495449108-31532-1-git-send-email-arvind.yadav.cs@gmail.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2017-05-22 at 16:01 +0530, Arvind Yadav wrote: > clk_prepare_enable() can fail here and we must check its return value. > Acked-by: Andy Shevchenko > Signed-off-by: Arvind Yadav > --- >  drivers/dma/dw/platform.c | 6 +++++- >  1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/dma/dw/platform.c b/drivers/dma/dw/platform.c > index c639c60..bc31fe8 100644 > --- a/drivers/dma/dw/platform.c > +++ b/drivers/dma/dw/platform.c > @@ -306,8 +306,12 @@ static int dw_resume_early(struct device *dev) >  { >   struct platform_device *pdev = to_platform_device(dev); >   struct dw_dma_chip *chip = platform_get_drvdata(pdev); > + int ret; > + > + ret = clk_prepare_enable(chip->clk); > + if (ret) > + return ret; >   > - clk_prepare_enable(chip->clk); >   return dw_dma_enable(chip); >  } >   -- Andy Shevchenko Intel Finland Oy