From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935164AbdEVScL (ORCPT ); Mon, 22 May 2017 14:32:11 -0400 Received: from smtprelay.synopsys.com ([198.182.47.9]:39390 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934222AbdEVScI (ORCPT ); Mon, 22 May 2017 14:32:08 -0400 From: Alexey Brodkin To: "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , Jose Abreu CC: Carlos Palminha , "ville.syrjala@linux.intel.com" , "a.hajda@samsung.com" , "architt@codeaurora.org" , "daniel.vetter@ffwll.ch" , "laurent.pinchart@ideasonboard.com" , "airlied@linux.ie" Subject: Re: [PATCH v4 05/10] drm: arc: Use crtc->mode_valid() callback Thread-Topic: [PATCH v4 05/10] drm: arc: Use crtc->mode_valid() callback Thread-Index: AQHS0DpHO5OtNA5JxEWchVpFl2kl+6IAkW0A Date: Mon, 22 May 2017 18:32:02 +0000 Message-ID: <1495477922.20961.26.camel@synopsys.com> References: <1f6db609f035e6183709e3b7364392c770341724.1495091280.git.joabreu@synopsys.com> In-Reply-To: <1f6db609f035e6183709e3b7364392c770341724.1495091280.git.joabreu@synopsys.com> Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.121.8.121] Content-Type: text/plain; charset="utf-8" Content-ID: <0AA9670C61AA204CA3A9C079A8822F73@internal.synopsys.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v4MIWL8H018361 Hi Jose, The only nitpicking note from my side is patch name. Probably full driver name as "arcpgu" might give a bit more context especially if later something else from ARC appears in "drm" folder. But IMHO that doesn't worth another respin. On Fri, 2017-05-19 at 01:52 +0100, Jose Abreu wrote: > Now that we have a callback to check if crtc supports a given mode > we can use it in arcpgu so that we restrict the number of probbed > modes to the ones we can actually display. > > This is specially useful because arcpgu crtc is responsible to set > a clock value in the commit() stage but unfortunatelly this clock > does not support all the needed ranges. > > Also, remove the atomic_check() callback as mode_valid() callback > will be called before. > > Signed-off-by: Jose Abreu > Cc: Carlos Palminha > Cc: Alexey Brodkin Reviewed-by: Alexey Brodkin