From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935236AbdEVTDF (ORCPT ); Mon, 22 May 2017 15:03:05 -0400 Received: from mga04.intel.com ([192.55.52.120]:15592 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760878AbdEVTDB (ORCPT ); Mon, 22 May 2017 15:03:01 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,378,1491289200"; d="scan'208";a="1151392512" Message-ID: <1495479778.6967.74.camel@linux.intel.com> Subject: Re: [PATCH v4 1/2] mfd: intel_soc_pmic: Select designware i2c-bus driver From: Andy Shevchenko To: Lee Jones , Hans de Goede Cc: linux-kernel@vger.kernel.org Date: Mon, 22 May 2017 22:02:58 +0300 In-Reply-To: <20170522105700.dyw7ade37z366nby@dell> References: <20170515182322.7583-1-hdegoede@redhat.com> <20170522105700.dyw7ade37z366nby@dell> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2017-05-22 at 11:57 +0100, Lee Jones wrote: > On Mon, 15 May 2017, Hans de Goede wrote: > > > The Crystal Cove PMIC provides an ACPI OPRegion handler, which must > > be > > available before other drivers using it are loaded, which is why > > INTEL_SOC_PMIC is a bool. > > > > Just having the driver is not enough, the driver for the i2c-bus > > must > > also be built in, to ensure this, this patch adds a select for it. > > > > This fixes errors like these during boot: > > > > mmc0: SDHCI controller on ACPI [80860F14:00] using ADMA > > ACPI Error: No handler for Region [REGS] (ffff93543b0cc3a8) > > [UserDefinedRegion] (20170119/evregion-166) > > ACPI Error: Region UserDefinedRegion (ID=143) has no handler > > (20170119/exfldio-299) > > ACPI Error: Method parse/execution failed [\_SB.PCI0.I2C7.PMI5.GET] > > (Node ffff93543b0cde10), AE_NOT_EXIST (20170119/psparse-543) > > ACPI Error: Method parse/execution failed [\_SB.PCI0.SHC1._PS0] > > (Node ffff93543b0b5cd0), AE_NOT_EXIST (20170119/psparse-543) > > acpi 80860F14:02: Failed to change power state to D0 > > > > While at it this patch also changes the human readable name of the > > Kconfig > > option to make clear the INTEL_SOC_PMIC option selects support for > > the > > Intel Crystal Cove PMIC and documents why this is a bool. > > > > Cc: Andy Shevchenko > > Signed-off-by: Hans de Goede > > Would be good to get an Ack by the users/maintainers of this driver. I'm not sure you will get (active) one. >>From my prospective, FWIW: Reviewed-by: Andy Shevchenko > > > --- > > Note this patch will partially conflicts with (contains the same > > changes as) > > a patch in Andy Shevchenko's tree. > > Has this been sorted now? >>From code it looks like (renaming is already done ---vvv).   > >  config INTEL_SOC_PMIC > >   bool "Support for Crystal Cove PMIC" -- Andy Shevchenko Intel Finland Oy