From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1761333AbdEWKtZ (ORCPT <rfc822;w@1wt.eu>);
        Tue, 23 May 2017 06:49:25 -0400
Received: from smtprelay0217.hostedemail.com ([216.40.44.217]:35976 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1751824AbdEWKtX (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 23 May 2017 06:49:23 -0400
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1568:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3865:3867:4321:5007:8957:10004:10400:10848:11026:11658:11914:12043:12296:12740:12760:12895:13069:13311:13357:13439:14659:14721:21080:21627:30030:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:55,LUA_SUMMARY:none
X-HE-Tag: bit83_519aeca64dd0b
X-Filterd-Recvd-Size: 1465
Message-ID: <1495536559.2093.56.camel@perches.com>
Subject: Re: staging: sm750fb: Replace CamelCase variable names with
 underscores
From: Joe Perches <joe@perches.com>
To: Richa Jha <richaj@cdac.in>, gregkh@linuxfoundation.org
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
        linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Date: Tue, 23 May 2017 03:49:19 -0700
In-Reply-To: <1495517476-31531-1-git-send-email-richaj@cdac.in>
References: <1495517476-31531-1-git-send-email-richaj@cdac.in>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.22.6-1ubuntu1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 2017-05-23 at 11:01 +0530, Richa Jha wrote:
>     Replace CamelCase variable names with underscores to comply with
>     the standard kernel coding style

Better would be to remove the hungarian prefixes too

> diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
[]
> @@ -55,7 +55,7 @@ static unsigned int get_mxclk_freq(void)
>  static void set_chip_clock(unsigned int frequency)
>  {
>  	struct pll_value pll;
> -	unsigned int ulActualMxClk;
> +	unsigned int ul_actual_max_clk;

	unsigned int actual_max_clk;

etc...