From: Eric Auger <eric.auger@redhat.com>
To: eric.auger.pro@gmail.com, eric.auger@redhat.com,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
kvmarm@lists.cs.columbia.edu, alex.williamson@redhat.com,
pbonzini@redhat.com, marc.zyngier@arm.com,
christoffer.dall@linaro.org
Cc: drjones@redhat.com, wei@redhat.com
Subject: [PATCH 04/10] VFIO: pci: Add automasked field to vfio_pci_irq_ctx
Date: Wed, 24 May 2017 22:13:17 +0200 [thread overview]
Message-ID: <1495656803-28011-5-git-send-email-eric.auger@redhat.com> (raw)
In-Reply-To: <1495656803-28011-1-git-send-email-eric.auger@redhat.com>
For direct EOI modality we will need to differentiate a userspace
masking from the IRQ handler auto-masking.
Signed-off-by: Eric Auger <eric.auger@redhat.com>
---
drivers/vfio/pci/vfio_pci_intrs.c | 15 +++++++++------
drivers/vfio/pci/vfio_pci_private.h | 1 +
2 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/vfio/pci/vfio_pci_intrs.c b/drivers/vfio/pci/vfio_pci_intrs.c
index 1c46045..d4d377b 100644
--- a/drivers/vfio/pci/vfio_pci_intrs.c
+++ b/drivers/vfio/pci/vfio_pci_intrs.c
@@ -52,7 +52,7 @@ void vfio_pci_intx_mask(struct vfio_pci_device *vdev)
if (unlikely(!is_intx(vdev))) {
if (vdev->pci_2_3)
pci_intx(pdev, 0);
- } else if (!vdev->ctx[0].masked) {
+ } else if (!vdev->ctx[0].masked && !vdev->ctx[0].automasked) {
/*
* Can't use check_and_mask here because we always want to
* mask, not just when something is pending.
@@ -90,7 +90,8 @@ static int vfio_pci_intx_unmask_handler(void *opaque, void *unused)
if (unlikely(!is_intx(vdev))) {
if (vdev->pci_2_3)
pci_intx(pdev, 1);
- } else if (vdev->ctx[0].masked && !vdev->virq_disabled) {
+ } else if ((vdev->ctx[0].masked || vdev->ctx[0].automasked) &&
+ !vdev->virq_disabled) {
/*
* A pending interrupt here would immediately trigger,
* but we can avoid that overhead by just re-sending
@@ -103,6 +104,7 @@ static int vfio_pci_intx_unmask_handler(void *opaque, void *unused)
enable_irq(pdev->irq);
vdev->ctx[0].masked = (ret > 0);
+ vdev->ctx[0].automasked = (ret > 0);
}
spin_unlock_irqrestore(&vdev->irqlock, flags);
@@ -126,11 +128,12 @@ static irqreturn_t vfio_intx_handler(int irq, void *dev_id)
if (!vdev->pci_2_3) {
disable_irq_nosync(vdev->pdev->irq);
- vdev->ctx[0].masked = true;
+ vdev->ctx[0].automasked = true;
ret = IRQ_HANDLED;
- } else if (!vdev->ctx[0].masked && /* may be shared */
- pci_check_and_mask_intx(vdev->pdev)) {
- vdev->ctx[0].masked = true;
+ } else if (!vdev->ctx[0].masked && !vdev->ctx[0].automasked &&
+ pci_check_and_mask_intx(vdev->pdev)) {
+ /* shared INTx */
+ vdev->ctx[0].automasked = true;
ret = IRQ_HANDLED;
}
diff --git a/drivers/vfio/pci/vfio_pci_private.h b/drivers/vfio/pci/vfio_pci_private.h
index f561ac1..f7f1101 100644
--- a/drivers/vfio/pci/vfio_pci_private.h
+++ b/drivers/vfio/pci/vfio_pci_private.h
@@ -35,6 +35,7 @@ struct vfio_pci_irq_ctx {
struct virqfd *mask;
char *name;
bool masked;
+ bool automasked;
struct irq_bypass_producer producer;
};
--
2.5.5
next prev parent reply other threads:[~2017-05-24 20:14 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 20:13 [PATCH 00/10] ARM/ARM64 Direct EOI setup for VFIO wired interrupts Eric Auger
2017-05-24 20:13 ` [PATCH 01/10] vfio: platform: Add automasked field to vfio_platform_irq Eric Auger
2017-05-25 18:05 ` Marc Zyngier
2017-05-30 12:45 ` Auger Eric
2017-05-31 17:41 ` Alex Williamson
2017-05-24 20:13 ` [PATCH 02/10] VFIO: platform: Introduce direct EOI interrupt handler Eric Auger
2017-05-31 18:20 ` Alex Williamson
2017-05-24 20:13 ` [PATCH 03/10] VFIO: platform: Direct EOI irq bypass for ARM/ARM64 Eric Auger
2017-05-31 18:20 ` Alex Williamson
2017-05-31 19:31 ` Auger Eric
2017-06-01 10:49 ` Marc Zyngier
2017-05-24 20:13 ` Eric Auger [this message]
2017-05-31 18:21 ` [PATCH 04/10] VFIO: pci: Add automasked field to vfio_pci_irq_ctx Alex Williamson
2017-05-24 20:13 ` [PATCH 05/10] VFIO: pci: Introduce direct EOI INTx interrupt handler Eric Auger
2017-05-31 18:24 ` Alex Williamson
2017-06-01 20:40 ` Auger Eric
2017-06-02 8:41 ` Marc Zyngier
2017-06-14 8:07 ` Auger Eric
2017-06-14 8:41 ` Marc Zyngier
2017-05-24 20:13 ` [PATCH 06/10] irqbypass: Add a private field in the producer Eric Auger
2017-05-24 20:13 ` [PATCH 07/10] VFIO: pci: Direct EOI irq bypass for ARM/ARM64 Eric Auger
2017-05-24 20:13 ` [PATCH 08/10] KVM: arm/arm64: vgic: Handle unshared mapped interrupts Eric Auger
2017-05-25 19:14 ` Marc Zyngier
2017-05-30 12:50 ` Auger Eric
2017-06-02 13:33 ` Christoffer Dall
2017-06-02 14:10 ` Marc Zyngier
2017-06-02 16:29 ` Christoffer Dall
2017-06-08 8:23 ` Marc Zyngier
2017-06-08 8:34 ` Christoffer Dall
2017-06-08 8:55 ` Auger Eric
2017-06-08 10:14 ` Christoffer Dall
2017-06-08 8:49 ` Auger Eric
2017-06-08 10:11 ` Christoffer Dall
2017-05-24 20:13 ` [PATCH 09/10] KVM: arm/arm64: vgic: Implement forwarding setting Eric Auger
2017-05-25 19:19 ` Marc Zyngier
2017-05-30 12:54 ` Auger Eric
2017-05-30 13:17 ` Marc Zyngier
2017-05-30 14:03 ` Auger Eric
2017-05-24 20:13 ` [PATCH 10/10] KVM: arm/arm64: register DEOI irq bypass consumer on ARM/ARM64 Eric Auger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495656803-28011-5-git-send-email-eric.auger@redhat.com \
--to=eric.auger@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=christoffer.dall@linaro.org \
--cc=drjones@redhat.com \
--cc=eric.auger.pro@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=pbonzini@redhat.com \
--cc=wei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).