From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S939281AbdEYVxL (ORCPT ); Thu, 25 May 2017 17:53:11 -0400 Received: from smtprelay0157.hostedemail.com ([216.40.44.157]:54209 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S939150AbdEYVxJ (ORCPT ); Thu, 25 May 2017 17:53:09 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3870:3871:4250:4321:4605:5007:6117:6119:7903:10004:10400:10848:11232:11658:11914:12043:12296:12555:12740:12760:12895:12986:13069:13311:13357:13439:14181:14659:14721:21080:21451:21627:30012:30045:30054:30083:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: crowd13_1b2ab632d5f26 X-Filterd-Recvd-Size: 2266 Message-ID: <1495749185.29207.21.camel@perches.com> Subject: Re: [PATCH v2] tpm: vtpm_proxy: Suppresse error logging when in closed state From: Joe Perches To: Stefan Berger , jarkko.sakkinen@linux.intel.com, tpmdd-devel@lists.sourceforge.net Cc: linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, jgunthorpe@obsidianresearch.com Date: Thu, 25 May 2017 14:53:05 -0700 In-Reply-To: <1495748360-26558-1-git-send-email-stefanb@linux.vnet.ibm.com> References: <1495748360-26558-1-git-send-email-stefanb@linux.vnet.ibm.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-05-25 at 17:39 -0400, Stefan Berger wrote: > Suppress the error logging when the core TPM driver sends commands > to the VTPM proxy driver and -EPIPE is returned in case the VTPM > proxy driver is 'closed' (closed anonymous file descriptor). This > error code is only returned by the send function and by tpm_transmit > when the VTPM proxy driver is being used. > > Signed-off-by: Stefan Berger > --- > drivers/char/tpm/tpm-interface.c | 4 ++-- > drivers/char/tpm/tpm2-cmd.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-interface.c > index d711186..4826fcf 100644 > --- a/drivers/char/tpm/tpm-interface.c > +++ b/drivers/char/tpm/tpm-interface.c > @@ -429,11 +429,11 @@ ssize_t tpm_transmit(struct tpm_chip *chip, struct tpm_space *space, > goto out; > > rc = chip->ops->send(chip, (u8 *) buf, count); > - if (rc < 0) { > + if (rc < 0 && rc != -EPIPE) > dev_err(&chip->dev, > "tpm_transmit: tpm_send: error %d\n", rc); > + if (rc < 0) > goto out; Perhaps this would read better as if (rc < 0) { if (rc != -EPIPE) dev_err(etc...); goto out; } though for etc, perhaps dev_err(&chip->dev, "%s: %tpm_send: error %d\n", __func__, rc);