From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1764310AbdEZNZf (ORCPT <rfc822;w@1wt.eu>);
        Fri, 26 May 2017 09:25:35 -0400
Received: from mx1.redhat.com ([209.132.183.28]:51582 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1761361AbdEZNZb (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 26 May 2017 09:25:31 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B96257D4EB
Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=riel@redhat.com
DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com B96257D4EB
Message-ID: <1495805128.29205.64.camel@redhat.com>
Subject: Re: [PATCH v3 2/8] x86/mm: Change the leave_mm() condition for
 local TLB flushes
From: Rik van Riel <riel@redhat.com>
To: Andy Lutomirski <luto@kernel.org>
Cc: X86 ML <x86@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Borislav Petkov <bpetkov@suse.de>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Mel Gorman <mgorman@suse.de>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        Nadav Amit <nadav.amit@gmail.com>, Dave Hansen <dave.hansen@intel.com>,
        Nadav Amit <namit@vmware.com>, Michal Hocko <mhocko@suse.com>,
        Arjan van de Ven <arjan@linux.intel.com>
Date: Fri, 26 May 2017 09:25:28 -0400
In-Reply-To: <CALCETrVDpWL4kQbxNVWBX-OKuThoaYaqefbKY-dD0A2y4BgNfA@mail.gmail.com>
References: <cover.1495759610.git.luto@kernel.org>
         <61de238db6d9c9018db020c41047ce32dac64488.1495759610.git.luto@kernel.org>
         <1495762747.29205.63.camel@redhat.com>
         <CALCETrVDpWL4kQbxNVWBX-OKuThoaYaqefbKY-dD0A2y4BgNfA@mail.gmail.com>
Organization: Red Hat, Inc
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Fri, 26 May 2017 13:25:31 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 2017-05-25 at 19:01 -0700, Andy Lutomirski wrote:
> On Thu, May 25, 2017 at 6:39 PM, Rik van Riel <riel@redhat.com>
> wrote:
> > On Thu, 2017-05-25 at 17:47 -0700, Andy Lutomirski wrote:
> > > 
> > > +++ b/arch/x86/mm/tlb.c
> > > @@ -311,7 +311,7 @@ void flush_tlb_mm_range(struct mm_struct *mm,
> > > unsigned long start,
> > >               goto out;
> > >       }
> > > 
> > > -     if (!current->mm) {
> > > +     if (this_cpu_read(cpu_tlbstate.state) != TLBSTATE_OK) {
> > >               leave_mm(smp_processor_id());
> > 
> > Unless -mm changed leave_mm (I did not check), this
> > is not quite correct yet.
> > 
> > The reason is leave_mm (at least in the latest Linus
> > tree) ignores the cpu argument for one of its checks.
> > 
> > You should probably fix that in an earlier patch,
> > assuming you haven't already done so in -mm.
> > 
> > void leave_mm(int cpu)
> > {
> >         struct mm_struct *active_mm =
> > this_cpu_read(cpu_tlbstate.active_mm);
> >         if (this_cpu_read(cpu_tlbstate.state) == TLBSTATE_OK)
> >                 BUG();
> >         if (cpumask_test_cpu(cpu, mm_cpumask(active_mm))) {
> >                 cpumask_clear_cpu(cpu, mm_cpumask(active_mm));
> >                 load_cr3(swapper_pg_dir);
> 
> I agree it's odd, but what's the bug?  Both before and after,
> leave_mm
> needed to be called with cpu == smp_processor_id(), and
> smp_processor_id() warns if it's called in a preemptible context.

Indeed, you are right. Looking at too much code at once...