From: Joe Perches <joe@perches.com>
To: tglx@linutronix.de, hpa@zytor.com, hch@lst.de,
mike.travis@hpe.com, mingo@kernel.org, sivanich@hpe.com,
linux-kernel@vger.kernel.org, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:timers/core] mmtimer: Remove the SGI SN2 mmtimer driver
Date: Fri, 26 May 2017 07:43:42 -0700 [thread overview]
Message-ID: <1495809822.29207.33.camel@perches.com> (raw)
In-Reply-To: <tip-07903ada96139ced48f2f893fe57a26a8fbc6043@git.kernel.org>
On Fri, 2017-05-26 at 03:58 -0700, tip-bot for Christoph Hellwig wrote:
> Commit-ID: 07903ada96139ced48f2f893fe57a26a8fbc6043
Couple trivial comments:
> mmtimer: Remove the SGI SN2 mmtimer driver
[]
> drivers/char/mmtimer.c | 858 ----------------------------------------------
> include/uapi/linux/time.h | 6 +-
[]
> diff --git a/drivers/char/mmtimer.c b/drivers/char/mmtimer.c
> deleted file mode 100644
> index 0e7fcb0..0000000
> --- a/drivers/char/mmtimer.c
> +++ /dev/null
> @@ -1,858 +0,0 @@
> -/*
[ etc...]
In the future, please use git format-patch -M to avoid
listing the
contents of the file deletion.
> diff --git a/include/uapi/linux/time.h b/include/uapi/linux/time.h
[]
> @@ -54,7 +54,11 @@ struct itimerval {
> #define CLOCK_BOOTTIME 7
> #define CLOCK_REALTIME_ALARM 8
> #define CLOCK_BOOTTIME_ALARM 9
> -#define CLOCK_SGI_CYCLE 10 /* Hardware specific */
> +/*
> + * The driver implementing this got removed. The clock ID is kept as a
> + * place holder. Do not reuse!
> + */
> +#define CLOCK_SGI_CYCLE 10
> #define CLOCK_TAI 11
>
> #define MAX_CLOCKS 16
Here the "this" comment is a bit ambiguous.
It might be better to rename CLOCK_SGI_CYCLE as well.
Maybe something like CLOCK_SGI_CYCLE_DELETED_DRIVER_DONT_REUSE.
next prev parent reply other threads:[~2017-05-26 14:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-26 9:03 constify struct k_clock Christoph Hellwig
2017-05-26 9:03 ` [PATCH 1/2] remove the SGI SN2 mmtimer driver Christoph Hellwig
2017-05-26 10:58 ` [tip:timers/core] mmtimer: Remove " tip-bot for Christoph Hellwig
2017-05-26 14:43 ` Joe Perches [this message]
2017-05-26 9:03 ` [PATCH 2/2] kernel: mark all struct k_clock instances const Christoph Hellwig
2017-05-26 9:35 ` Joe Perches
2017-05-26 10:32 ` Thomas Gleixner
2017-05-26 16:09 ` Joe Perches
2017-05-26 10:58 ` [tip:timers/core] posix-timers: Make posix_clocks immutable tip-bot for Christoph Hellwig
2017-05-26 12:39 ` tip-bot for Christoph Hellwig
2017-05-26 12:40 ` tip-bot for Christoph Hellwig
2017-05-27 7:52 ` tip-bot for Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495809822.29207.33.camel@perches.com \
--to=joe@perches.com \
--cc=hch@lst.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mike.travis@hpe.com \
--cc=mingo@kernel.org \
--cc=sivanich@hpe.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox