From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932619AbdE0BUe (ORCPT <rfc822;w@1wt.eu>);
        Fri, 26 May 2017 21:20:34 -0400
Received: from smtprelay0233.hostedemail.com ([216.40.44.233]:50330 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1948851AbdEZXmR (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 26 May 2017 19:42:17 -0400
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:960:965:966:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2196:2199:2393:2553:2559:2562:2828:2898:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3870:3872:3874:4321:4385:4390:4395:4605:5007:6119:7875:7974:10004:10400:10848:11232:11658:11914:12296:12740:12760:12895:13069:13163:13229:13255:13311:13357:13439:14659:14721:21080:21325:21451:21627:30012:30054:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none
X-HE-Tag: move67_1236249b1a036
X-Filterd-Recvd-Size: 2039
Message-ID: <1495842124.9389.2.camel@perches.com>
Subject: Re: [PATCH v3 1/1] partitions/msdos: FreeBSD UFS2 file systems are
 not recognized
From: Joe Perches <joe@perches.com>
To: Richard Narron <comet.berkeley@gmail.com>
Cc: linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
        Jens Axboe <axboe@kernel.dk>, Andries Brouwer <aeb@cwi.nl>
Date: Fri, 26 May 2017 16:42:04 -0700
In-Reply-To: <alpine.LNX.2.21.1705261612360.2379@joy.test>
References: <alpine.LNX.2.21.1705260343290.1853@joy.test>
         <1495809112.29207.30.camel@perches.com>
         <alpine.LNX.2.21.1705261612360.2379@joy.test>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.22.6-1ubuntu1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 2017-05-26 at 16:30 -0700, Richard Narron wrote:
> On Fri, 26 May 2017, Joe Perches wrote:
> 
> > On Fri, 2017-05-26 at 03:48 -0700, Richard Narron wrote:
> > > The code in block/partitions/msdos.c recognizes FreeBSD, OpenBSD
> > > and NetBSD partitions and does a reasonable job picking out OpenBSD
> > > and NetBSD UFS subpartitions.
> > > 
> > > But for FreeBSD the subpartitions are always "bad".
> > > 
> > >      Kernel: <bsd:bad subpartition - ignored
> > 
> > []
> > >   block/partitions/msdos.c | 2 ++
> > 
> > []
> > > @@ -300,6 +300,8 @@ static void parse_bsd(struct parsed_part
> > >   			continue;
> > >   		bsd_start = le32_to_cpu(p->p_offset);
> > >   		bsd_size = le32_to_cpu(p->p_size);
> > > +		if (memcmp(flavour, "bsd\0", 4) == 0)
> > 
> > Weird code.  Why not:
> > 
> > 		if (strcmp(flavor, "bsd") == 0)
> > 
> 
> I instinctively trust the memcmp function as it seems more like 
> assembly language to me and more straight forward and more reliable than 
> strcmp.

That really doesn't matter.

Your code stores "bsd\0\0" and not just "bsd\0"