From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751103AbdE2PPU (ORCPT ); Mon, 29 May 2017 11:15:20 -0400 Received: from smtprelay.synopsys.com ([198.182.60.111]:50117 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751000AbdE2PPT (ORCPT ); Mon, 29 May 2017 11:15:19 -0400 From: Alexey Brodkin To: "noamca@mellanox.com" , "linux-snps-arc@lists.infradead.org" CC: "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 07/11] ARC: [plat-eznps] disabled stall counter due to a HW bug Thread-Topic: [PATCH v2 07/11] ARC: [plat-eznps] disabled stall counter due to a HW bug Thread-Index: AQHS138FuXuy7B82N0GpmzzzyN/UbKILTDkA Date: Mon, 29 May 2017 15:15:15 +0000 Message-ID: <1496070914.7990.19.camel@synopsys.com> References: <1495954328-28736-1-git-send-email-noamca@mellanox.com> <1495954328-28736-8-git-send-email-noamca@mellanox.com> In-Reply-To: <1495954328-28736-8-git-send-email-noamca@mellanox.com> Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.121.3.38] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v4TFFO5O007672 Hi Noam, On Sun, 2017-05-28 at 09:52 +0300, Noam Camus wrote: > From: Noam Camus > > This counter represents threshold for consecutive stall that which > trigger HW threads scheduling. > When this feature is enabled low values of this counter cause > downgrade in performance and in the worst case even a livelock. > > Remove those couple of lines and resort to HW reset value i.e. > this feature is disabled (.sten field equals 0). Looks like you made a change I was asking for here. But there's no mention of the change so it's easy to not note that change. Not critical but please add a changelog next time  even if it's only a comment message that was modified since the previous revision. Otherwise... Reviewed-by: Alexey Brodkin > Signed-off-by: Noam Camus > --- >  arch/arc/plat-eznps/mtm.c |    2 -- >  1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/arch/arc/plat-eznps/mtm.c b/arch/arc/plat-eznps/mtm.c > index aaaaffd..e0cb36b 100644 > --- a/arch/arc/plat-eznps/mtm.c > +++ b/arch/arc/plat-eznps/mtm.c > @@ -119,8 +119,6 @@ void mtm_enable_core(unsigned int cpu) >   mt_ctrl.value = 0; >   mt_ctrl.hsen = 1; >   mt_ctrl.hs_cnt = MT_CTRL_HS_CNT; > - mt_ctrl.sten = 1; > - mt_ctrl.st_cnt = MT_CTRL_ST_CNT; >   mt_ctrl.mten = 1; >   write_aux_reg(CTOP_AUX_MT_CTRL, mt_ctrl.value); >