From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750983AbdE2Rgd (ORCPT ); Mon, 29 May 2017 13:36:33 -0400 Received: from smtprelay0105.hostedemail.com ([216.40.44.105]:40382 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750844AbdE2Rgb (ORCPT ); Mon, 29 May 2017 13:36:31 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1714:1730:1747:1777:1792:2198:2199:2393:2553:2559:2562:2828:2911:3138:3139:3140:3141:3142:3350:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4250:4321:4425:5007:6119:7903:8531:10004:10400:10848:11026:11232:11473:11658:11783:11914:12043:12438:12679:12740:12895:13069:13161:13229:13311:13357:13439:13894:14181:14659:14721:21080:21433:21451:21627:30054:30060:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: spy82_38a447afc1c3a X-Filterd-Recvd-Size: 3128 Message-ID: <1496079388.18529.3.camel@perches.com> Subject: Re: [PATCH 01/12] staging: ccree: correct coding style violations From: Joe Perches To: Gilad Ben-Yossef Cc: Greg Kroah-Hartman , linux-crypto@vger.kernel.org, devel@driverdev.osuosl.org, driverdev-devel@linuxdriverproject.org, Linux kernel mailing list , Ofir Drang Date: Mon, 29 May 2017 10:36:28 -0700 In-Reply-To: References: <1495982440-10047-1-git-send-email-gilad@benyossef.com> <1495982440-10047-2-git-send-email-gilad@benyossef.com> <20170529143728.GA12428@kroah.com> <1496077030.18529.1.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2017-05-29 at 20:11 +0300, Gilad Ben-Yossef wrote: > On Mon, May 29, 2017 at 7:57 PM, Joe Perches wrote: > > On Mon, 2017-05-29 at 16:37 +0200, Greg Kroah-Hartman wrote: > > > On Sun, May 28, 2017 at 05:40:26PM +0300, Gilad Ben-Yossef wrote: > > > > cc_crypto_ctx.h had multiple coding style violations reported by > > > > checkpatch. Fix them all. > > > > > > Sorry, no. You need to do only one-thing-per-patch, and "fix all coding > > > style issues is not "one thing". I wouldn't take this kind of patch > > > from anyone else, so why should I take it from you? :) > > > > Because he's the named MAINTAINER of the subsystem > > and you are acting as an upstream conduit. > > > > LOL. Thank you Joe, but I have opted to upstream via staging to get the guidance > and review of Greg and other developers kind enough to offer it, and I'd be a > fool not to listen to them. For reviews of technical merit, true. For reviews of commit log wording of whitespace changes, where git diff -w shows no difference, less true. This patch seems almost entirely whitespace except one bit reformatting a comment block. Breaking those down into changes like: added space after commas added spaces around bit shifts added spaces around arithmetic is simply excessive. The only comment I would have given would be to change the patch context that added line comment initiators to use the /** kernel-doc style. And maybe a style change of #define CC_MULTI2_SYSTEM_N_DATA_KEY_SIZE (CC_MULTI2_SYSTEM_KEY_SIZE + \   CC_MULTI2_DATA_KEY_SIZE) to #define CC_MULTI2_SYSTEM_N_DATA_KEY_SIZE \ (CC_MULTI2_SYSTEM_KEY_SIZE + CC_MULTI2_DATA_KEY_SIZE) as it's sometimes easier to scan arithmetic on a single line. btw: this #define seems misleading as it's used in both .min_keysize and .max_keysize with "+ 1" and key[CC_MULTI2_SYSTEM_N_DATA_KEY_SIZE] is also used.