From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751094AbdE3KWu (ORCPT ); Tue, 30 May 2017 06:22:50 -0400 Received: from smtprelay0130.hostedemail.com ([216.40.44.130]:37658 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750890AbdE3KWt (ORCPT ); Tue, 30 May 2017 06:22:49 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:334:355:368:369:379:541:599:800:960:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3872:4321:4362:4605:4823:5007:7576:10004:10400:10848:11026:11232:11658:11914:12043:12048:12296:12438:12555:12740:12760:12895:12986:13069:13255:13311:13357:13439:14181:14659:14721:21080:21627:30054:30089:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:82,LUA_SUMMARY:none X-HE-Tag: birth56_6ddab22e6b903 X-Filterd-Recvd-Size: 1763 Message-ID: <1496139753.2618.21.camel@perches.com> Subject: Re: [PATCH] ALSA: sound/core/pcm_timer.c: include pcm_local.h and remove some extraneous tabs From: Joe Perches To: Colin King , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 30 May 2017 03:22:33 -0700 In-Reply-To: <20170530095830.31534-1-colin.king@canonical.com> References: <20170530095830.31534-1-colin.king@canonical.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-05-30 at 10:58 +0100, Colin King wrote: > From: Colin Ian King > > We need to include pcm_local.h to clean up some smatch warnings: > > symbol 'snd_pcm_timer_done' was not declared. Should it be static? > symbol 'snd_pcm_timer_init' was not declared. Should it be static? > symbol 'snd_pcm_timer_resolution_change' was not declared. Should > it be static? > > Also remove some extraneous tabs on empty lines. Thanks. trivia: > diff --git a/sound/core/pcm_timer.c b/sound/core/pcm_timer.c [] > @@ -33,7 +35,7 @@ void snd_pcm_timer_resolution_change(struct snd_pcm_substream *substream) > { > unsigned long rate, mult, fsize, l, post; > struct snd_pcm_runtime *runtime = substream->runtime; > - > + > mult = 1000000000; > rate = runtime->rate; Maybe fix the mult indentation too?