From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751540AbdE3NGD (ORCPT <rfc822;w@1wt.eu>);
        Tue, 30 May 2017 09:06:03 -0400
Received: from mga07.intel.com ([134.134.136.100]:59432 "EHLO mga07.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751151AbdE3NGA (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 30 May 2017 09:06:00 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.38,418,1491289200"; 
   d="scan'208";a="1176043808"
Message-ID: <1496149552.28981.24.camel@linux.intel.com>
Subject: Re: [PATCH v8] mfd: Add Cherry Trail Whiskey Cove PMIC driver
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Lee Jones <lee.jones@linaro.org>,
        Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Wolfram Sang <wsa@the-dreams.de>, Hans de Goede <hdegoede@redhat.com>,
        Paul Gortmaker <paul.gortmaker@windriver.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Bin Gao <bin.gao@intel.com>,
        Felipe Balbi <felipe.balbi@linux.intel.com>
Date: Tue, 30 May 2017 16:05:52 +0300
In-Reply-To: <20170530122003.scaw5f7diez7uhl6@dell>
References: <20170523212434.12981-1-hdegoede@redhat.com>
         <20170530090214.s2f4ivj7ahiabhml@dell>
         <CAHp75Vcg2AmHnyPSx3b1Na1w2XBAT7CLkrWAHA5jEBVa5foCuw@mail.gmail.com>
         <20170530122003.scaw5f7diez7uhl6@dell>
Organization: Intel Finland Oy
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.22.6-1 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 2017-05-30 at 13:20 +0100, Lee Jones wrote:
> On Tue, 30 May 2017, Andy Shevchenko wrote:
> 
> > On Tue, May 30, 2017 at 12:02 PM, Lee Jones <lee.jones@linaro.org>
> > wrote:
> > > On Tue, 23 May 2017, Hans de Goede wrote:
> > > > +static const struct i2c_device_id cht_wc_i2c_id[] = {
> > > > +     { }
> > > > +};
> > > 
> > > What's the point in this empty table?
> > 
> > This is artifact of I2C framework, otherwise if will be not
> > enumerated.
> > 
> > +Wolfram.
> > 
> > Wolfram, can we fix this? (In case we have either ACPI table or OF
> > table there is no need to oblige providing empty legacy table)
> 
> I think I fixed this already.
> 
> Hint: `git grep probe_new -- drivers/i2c`

Indeed.
Thanks for a hint!

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy