From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751053AbdE3RYA (ORCPT ); Tue, 30 May 2017 13:24:00 -0400 Received: from smtprelay0023.hostedemail.com ([216.40.44.23]:54890 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750911AbdE3RX7 (ORCPT ); Tue, 30 May 2017 13:23:59 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3870:3872:3874:4321:5007:6119:6691:7514:7903:10004:10400:10848:11232:11658:11914:12043:12740:12760:12895:13069:13161:13229:13311:13357:13439:14181:14659:14721:21080:21433:21451:21627:30034:30054:30070:30080:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: arch03_540aaf8f8a4a X-Filterd-Recvd-Size: 2248 Message-ID: <1496165034.2618.26.camel@perches.com> Subject: Re: [PATCH] Input: synaptics-rmi4 - use %ph to form F34 configuration ID From: Joe Perches To: Dmitry Torokhov , Benjamin Tissoires , Andy Shevchenko Cc: linux-input@vger.kernel.org, Nick Dyer , Dan Carpenter , linux-kernel@vger.kernel.org Date: Tue, 30 May 2017 10:23:54 -0700 In-Reply-To: <20170530165913.GD12922@dtor-ws> References: <20170530044944.GA33451@dtor-ws> <20170530082358.GB1293@mail.corp.redhat.com> <20170530165913.GD12922@dtor-ws> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-05-30 at 09:59 -0700, Dmitry Torokhov wrote: > On Tue, May 30, 2017 at 10:23:58AM +0200, Benjamin Tissoires wrote: > > On May 29 2017 or thereabouts, Dmitry Torokhov wrote: > > > Instead of printing bytes one by one, let's use %phN to print the buffer in > > > one go. > > > > > > Also use hweight8 to count number of partitions instead of inspecting it > > > bit by bit. > > > > > > Signed-off-by: Dmitry Torokhov > > > --- > > > > Looks good to me: > > Reviewed-by: Benjamin Tissoires > > Hm, I just realized taht we'd go from upper to lowercase hex digits. I > think it should be OK, but I'd like to hear interested parties (Nick). > > Or we'd need to introduce %pH I guess. As it's debugging output, I'd hazard to guess it doesn't matter. If someone _really_ needs upper-case output in *ph, I'd also suggest adding another qualifier to keep the number of letter prefixes used down. %ph[CDNU]. A pity that %ph[cdnCDN] isn't possible as that's the style used by %pU[blBL] for lower/upper case output. There are < 80 uses of %[\*\d]+ph[CDN], maybe it'd be reasonable to do a treewide sed to lowercase for them. Dunno.