From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751056AbdE3TR3 (ORCPT ); Tue, 30 May 2017 15:17:29 -0400 Received: from smtprelay0238.hostedemail.com ([216.40.44.238]:33353 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750825AbdE3TR1 (ORCPT ); Tue, 30 May 2017 15:17:27 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:960:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2691:2828:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3874:4321:5007:6691:7903:10004:10400:10848:11232:11658:11783:11914:12296:12663:12740:12895:13069:13311:13357:13439:13894:14659:14721:21080:21433:21627:30054:30070:30080:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: bulb16_7ac814b3b2c0e X-Filterd-Recvd-Size: 2570 Message-ID: <1496171842.2618.30.camel@perches.com> Subject: Re: [PATCH] Input: synaptics-rmi4 - use %ph to form F34 configuration ID From: Joe Perches To: Andy Shevchenko , Dmitry Torokhov , Benjamin Tissoires Cc: linux-input@vger.kernel.org, Nick Dyer , Dan Carpenter , linux-kernel@vger.kernel.org Date: Tue, 30 May 2017 12:17:22 -0700 In-Reply-To: <1496171059.28981.33.camel@linux.intel.com> References: <20170530044944.GA33451@dtor-ws> <20170530082358.GB1293@mail.corp.redhat.com> <20170530165913.GD12922@dtor-ws> <1496165034.2618.26.camel@perches.com> <1496171059.28981.33.camel@linux.intel.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-05-30 at 22:04 +0300, Andy Shevchenko wrote: > On Tue, 2017-05-30 at 10:23 -0700, Joe Perches wrote: > > On Tue, 2017-05-30 at 09:59 -0700, Dmitry Torokhov wrote: > > > On Tue, May 30, 2017 at 10:23:58AM +0200, Benjamin Tissoires wrote: > > > > On May 29 2017 or thereabouts, Dmitry Torokhov wrote: > > > > > > > > Or we'd need to introduce %pH I guess. > > > > As it's debugging output, I'd hazard to guess it doesn't matter. > > > > If someone _really_ needs upper-case output in *ph, > > Starting from the same... > > > > A pity that %ph[cdnCDN] isn't possible as that's the style used > > by %pU[blBL] for lower/upper case output. > > > > There are < 80 uses of %[\*\d]+ph[CDN], maybe it'd be reasonable > > to do a treewide sed to lowercase for them.  Dunno. It's more like ~300 when the grep is done properly, -E needed to be -P, so I believe that's too many to bother with a treewide sed. > And I think less intrusive would be > %pH[CDN] > since the latter proposal misses plain %*ph use. No it wouldn't necessarily. %*phU could still be upper case too. > But for now I would rather avoid it at all, I'm pretty sure there very > rare cases when one needs > 1) to print a dump, *and* > 2) it should be upper cased. Doubtful, but maybe there is a seq_ use somewhere that could be converted. Anyway I think the proposed change in the original patch is fine and nothing else needs to be done.