Re: [rcu:rcu/next 97/97] arch/blackfin/kernel/module.c:20:25: error: expected ')' before 'fmt'

[Joe Perches <joe@perches.com>]

Hey Paul.

Can you please fix the mod_debug macro definition
as described below?

Thanks.  Joe

On Wed, 2017-05-31 at 08:48 +0800, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git rcu/next
> head:   19223c8730d289cd4c65b46250b3e02a6752803c
> commit: 19223c8730d289cd4c65b46250b3e02a6752803c [97/97] module: Fix pr_fmt() bug for header use of printk
> config: blackfin-allmodconfig (attached as .config)
> compiler: bfin-uclinux-gcc (GCC) 6.2.0
> reproduce:
>         wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout 19223c8730d289cd4c65b46250b3e02a6752803c
>         # save the attached .config to linux build tree
>         make.cross ARCH=blackfin 
> 
> All error/warnings (new ones prefixed by >>):
> 
>    In file included from include/linux/printk.h:329:0,
>                     from include/linux/kernel.h:13,
>                     from include/linux/list.h:8,
>                     from include/linux/module.h:9,
>                     from include/linux/moduleloader.h:5,
>                     from arch/blackfin/kernel/module.c:7:
>    arch/blackfin/kernel/module.c: In function 'apply_relocate_add':
> > > arch/blackfin/kernel/module.c:20:25: error: expected ')' before 'fmt'
> 
>      pr_debug("module %s: " fmt, (mod)->name, ##__VA_ARGS__)
>                             ^
>    include/linux/dynamic_debug.h:79:14: note: in definition of macro 'DEFINE_DYNAMIC_DEBUG_METADATA_KEY'
>       .format = (fmt),    \
[]
> vim +20 arch/blackfin/kernel/module.c
> 
[]
>     19	#define mod_debug(mod, ...)						\

duh.

This line needs to be:

#define mod_debug(mod, fmt, ...)							\

so fmt is one of the arguments to mod_debug

>   > 20		pr_debug("module %s: " fmt, (mod)->name, ##__VA_ARGS__)