From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751162AbdFAW0N (ORCPT ); Thu, 1 Jun 2017 18:26:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60950 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751078AbdFAW0M (ORCPT ); Thu, 1 Jun 2017 18:26:12 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 63D6880C01 Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=dledford@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 63D6880C01 Message-ID: <1496355969.7171.65.camel@redhat.com> Subject: Re: [PATCH] IB/IPoIB: Replace netdev_priv with ipoib_priv for ipoib_get_link_ksettings From: Doug Ledford To: Yanjun Zhu , Leon Romanovsky , Yuval Shaia Cc: Honggang LI , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 01 Jun 2017 18:26:09 -0400 In-Reply-To: <92da39f0-2c7a-5039-234e-94da89d5eacb@oracle.com> References: <1494504868-17204-1-git-send-email-honli@redhat.com> <20170511123109.GC18962@yuval-lap> <20170511124020.GH3616@mtr-leonro.local> <92da39f0-2c7a-5039-234e-94da89d5eacb@oracle.com> Organization: Red Hat, Inc. Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 01 Jun 2017 22:26:11 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-05-19 at 11:15 +0800, Yanjun Zhu wrote: > >> Suggesting to remove kernel oops from commit log message, fix is > trivial. > > Please don't, they are useful. > Can we explain this in commit log message? > > The patch "IB/IPoIB: Support acceleration options callbacks" makes  > ipoib_pirv different from netdev_priv. I reworked the commit message considerably to resolve this issue, and then applied the patch. -- Doug Ledford     GPG KeyID: B826A3330E572FDD     Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD