From: Doug Ledford <dledford@redhat.com>
To: Qing Huang <qing.huang@oracle.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: sean.hefty@intel.com, artemyko@mellanox.com
Subject: Re: [PATCH] ib/core: not to set page dirty bit if it's already set.
Date: Thu, 01 Jun 2017 18:33:59 -0400 [thread overview]
Message-ID: <1496356439.7171.73.camel@redhat.com> (raw)
In-Reply-To: <20170518233353.14370-1-qing.huang@oracle.com>
On Thu, 2017-05-18 at 16:33 -0700, Qing Huang wrote:
> This change will optimize kernel memory deregistration operations.
> __ib_umem_release() used to call set_page_dirty_lock() against every
> writable page in its memory region. Its purpose is to keep data
> synced between CPU and DMA device when swapping happens after mem
> deregistration ops. Now we choose not to set page dirty bit if it's
> already set by kernel prior to calling __ib_umem_release(). This
> reduces memory deregistration time by half or even more when we ran
> application simulation test program.
>
> Signed-off-by: Qing Huang <qing.huang@oracle.com>
Thanks, applied.
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
prev parent reply other threads:[~2017-06-01 22:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 23:33 [PATCH] ib/core: not to set page dirty bit if it's already set Qing Huang
2017-05-19 13:05 ` Christoph Hellwig
2017-05-22 23:43 ` Qing Huang
2017-05-23 7:42 ` Christoph Hellwig
2017-05-23 21:39 ` Qing Huang
2017-06-01 22:33 ` Doug Ledford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1496356439.7171.73.camel@redhat.com \
--to=dledford@redhat.com \
--cc=artemyko@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=qing.huang@oracle.com \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox