From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751170AbdFAWeD (ORCPT ); Thu, 1 Jun 2017 18:34:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54880 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751078AbdFAWeB (ORCPT ); Thu, 1 Jun 2017 18:34:01 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 42EBDC04B92A Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=dledford@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 42EBDC04B92A Message-ID: <1496356439.7171.73.camel@redhat.com> Subject: Re: [PATCH] ib/core: not to set page dirty bit if it's already set. From: Doug Ledford To: Qing Huang , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Cc: sean.hefty@intel.com, artemyko@mellanox.com Date: Thu, 01 Jun 2017 18:33:59 -0400 In-Reply-To: <20170518233353.14370-1-qing.huang@oracle.com> References: <20170518233353.14370-1-qing.huang@oracle.com> Organization: Red Hat, Inc. Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 01 Jun 2017 22:34:01 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-05-18 at 16:33 -0700, Qing Huang wrote: > This change will optimize kernel memory deregistration operations. > __ib_umem_release() used to call set_page_dirty_lock() against every > writable page in its memory region. Its purpose is to keep data > synced between CPU and DMA device when swapping happens after mem > deregistration ops. Now we choose not to set page dirty bit if it's > already set by kernel prior to calling __ib_umem_release(). This > reduces memory deregistration time by half or even more when we ran > application simulation test program. > > Signed-off-by: Qing Huang Thanks, applied. -- Doug Ledford     GPG KeyID: B826A3330E572FDD     Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD