From: "Pali Rohár" <pali.rohar@gmail.com>
To: Joern Engel <joern@lazybastard.org>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Marek Vasut <marek.vasut@gmail.com>,
Richard Weinberger <richard@nod.at>,
Cyrille Pitchen <cyrille.pitchen@atmel.com>,
Artem Bityutskiy <dedekind1@gmail.com>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
"Pali Rohár" <pali.rohar@gmail.com>
Subject: [PATCH 1/5] mtd: block2mtd: Check for valid user supplied erase size
Date: Fri, 2 Jun 2017 17:43:38 +0200 [thread overview]
Message-ID: <1496418222-23483-2-git-send-email-pali.rohar@gmail.com> (raw)
In-Reply-To: <1496418222-23483-1-git-send-email-pali.rohar@gmail.com>
Erase size is limited to 32bit unsigned integer, but value parsed from user
is limited up to size_t C type.
Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
---
drivers/mtd/devices/block2mtd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/devices/block2mtd.c b/drivers/mtd/devices/block2mtd.c
index 7c887f1..ee47cdd 100644
--- a/drivers/mtd/devices/block2mtd.c
+++ b/drivers/mtd/devices/block2mtd.c
@@ -419,7 +419,7 @@ static int block2mtd_setup2(const char *val)
if (token[1]) {
ret = parse_num(&erase_size, token[1]);
- if (ret) {
+ if (ret || erase_size > U32_MAX) {
pr_err("illegal erase size\n");
return 0;
}
--
1.7.9.5
next prev parent reply other threads:[~2017-06-02 15:44 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-02 15:43 [PATCH 0/5] Extends block2mtd and ubi drivers Pali Rohár
2017-06-02 15:43 ` Pali Rohár [this message]
2017-07-21 19:45 ` [PATCH 1/5] mtd: block2mtd: Check for valid user supplied erase size Richard Weinberger
2017-06-02 15:43 ` [PATCH 2/5] mtd: block2mtd: Add support for specifying MTD write size and subpage shift Pali Rohár
2017-06-02 16:13 ` Richard Weinberger
2017-06-05 11:21 ` Pali Rohár
2017-06-05 11:23 ` Richard Weinberger
2017-06-05 11:25 ` Pali Rohár
2017-06-05 11:27 ` Richard Weinberger
2017-06-07 8:46 ` Pali Rohár
2017-06-18 10:06 ` Pavel Machek
2017-06-18 10:11 ` Richard Weinberger
2017-07-17 12:34 ` Pali Rohár
2017-06-02 15:43 ` [PATCH 3/5] mtd: block2mtd: Fallback to read-only mode Pali Rohár
2017-07-21 19:53 ` Richard Weinberger
2017-07-25 14:28 ` Pali Rohár
2017-06-02 15:43 ` [PATCH 4/5] mtd: block2mtd: Add support for deleting block2mtd mapping Pali Rohár
2017-07-21 19:56 ` Richard Weinberger
2017-07-25 14:24 ` Pali Rohár
2017-08-06 9:39 ` Richard Weinberger
2017-06-02 15:43 ` [PATCH 5/5] ubi: Allow to use read-only UBI volume with not enough PEBs Pali Rohár
2017-07-21 20:12 ` Richard Weinberger
2017-07-25 14:27 ` Pali Rohár
2017-08-06 9:43 ` Richard Weinberger
2017-08-06 10:30 ` Pali Rohár
2017-06-02 16:17 ` [PATCH 0/5] Extends block2mtd and ubi drivers Richard Weinberger
2017-06-05 11:18 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1496418222-23483-2-git-send-email-pali.rohar@gmail.com \
--to=pali.rohar@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@atmel.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=joern@lazybastard.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).