linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefano Stabellini <sstabellini@kernel.org>
To: xen-devel@lists.xen.org
Cc: linux-kernel@vger.kernel.org, sstabellini@kernel.org,
	jgross@suse.com, boris.ostrovsky@oracle.com,
	Stefano Stabellini <stefano@aporeto.com>
Subject: [PATCH v3 17/18] xen/pvcalls: implement write
Date: Fri,  2 Jun 2017 12:31:54 -0700	[thread overview]
Message-ID: <1496431915-20774-17-git-send-email-sstabellini@kernel.org> (raw)
In-Reply-To: <1496431915-20774-1-git-send-email-sstabellini@kernel.org>

When the other end notifies us that there is data to be written
(pvcalls_back_conn_event), increment the io and write counters, and
schedule the ioworker.

Implement the write function called by ioworker by reading the data from
the data ring, writing it to the socket by calling inet_sendmsg.

Set out_error on error.

Signed-off-by: Stefano Stabellini <stefano@aporeto.com>
CC: boris.ostrovsky@oracle.com
CC: jgross@suse.com
---
 drivers/xen/pvcalls-back.c | 74 +++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 73 insertions(+), 1 deletion(-)

diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c
index e7d2b85..fe3e70f 100644
--- a/drivers/xen/pvcalls-back.c
+++ b/drivers/xen/pvcalls-back.c
@@ -180,7 +180,66 @@ static void pvcalls_conn_back_read(unsigned long opaque)
 
 static int pvcalls_conn_back_write(struct sock_mapping *map)
 {
-	return 0;
+	struct pvcalls_data_intf *intf = map->ring;
+	struct pvcalls_data *data = &map->data;
+	struct msghdr msg;
+	struct kvec vec[2];
+	RING_IDX cons, prod, size, ring_size;
+	int ret;
+
+	cons = intf->out_cons;
+	prod = intf->out_prod;
+	/* read the indexes before dealing with the data */
+	virt_mb();
+
+	ring_size = XEN_FLEX_RING_SIZE(map->ring_order);
+	size = pvcalls_queued(prod, cons, ring_size);
+	if (size == 0)
+		return 0;
+
+	memset(&msg, 0, sizeof(msg));
+	msg.msg_flags |= MSG_DONTWAIT;
+	msg.msg_iter.type = ITER_KVEC|READ;
+	msg.msg_iter.count = size;
+	if (pvcalls_mask(prod, ring_size) > pvcalls_mask(cons, ring_size)) {
+		vec[0].iov_base = data->out + pvcalls_mask(cons, ring_size);
+		vec[0].iov_len = size;
+		msg.msg_iter.kvec = vec;
+		msg.msg_iter.nr_segs = 1;
+	} else {
+		vec[0].iov_base = data->out + pvcalls_mask(cons, ring_size);
+		vec[0].iov_len = ring_size - pvcalls_mask(cons, ring_size);
+		vec[1].iov_base = data->out;
+		vec[1].iov_len = size - vec[0].iov_len;
+		msg.msg_iter.kvec = vec;
+		msg.msg_iter.nr_segs = 2;
+	}
+
+	atomic_set(&map->write, 0);
+	ret = inet_sendmsg(map->sock, &msg, size);
+	if (ret == -EAGAIN || ret < size) {
+		atomic_inc(&map->write);
+		atomic_inc(&map->io);
+	}
+	if (ret == -EAGAIN)
+		return ret;
+
+	/* write the data, then update the indexes */
+	virt_wmb();
+	if (ret < 0) {
+		intf->out_error = ret;
+	} else {
+		intf->out_error = 0;
+		intf->out_cons = cons + ret;
+		prod = intf->out_prod;
+	}
+	/* update the indexes, then notify the other end */
+	virt_wmb();
+	if (prod != cons + ret)
+		atomic_inc(&map->write);
+	notify_remote_via_irq(map->irq);
+
+	return ret;
 }
 
 static void pvcalls_back_ioworker(struct work_struct *work)
@@ -837,6 +896,19 @@ static irqreturn_t pvcalls_back_event(int irq, void *dev_id)
 
 static irqreturn_t pvcalls_back_conn_event(int irq, void *sock_map)
 {
+	struct sock_mapping *map = sock_map;
+	struct pvcalls_ioworker *iow;
+
+	if (map == NULL || map->sock == NULL || map->sock->sk == NULL ||
+		map->sock->sk->sk_user_data != map)
+		return IRQ_HANDLED;
+
+	iow = &map->ioworker;
+
+	atomic_inc(&map->write);
+	atomic_inc(&map->io);
+	queue_work_on(iow->cpu, iow->wq, &iow->register_work);
+
 	return IRQ_HANDLED;
 }
 
-- 
1.9.1

  parent reply	other threads:[~2017-06-02 19:32 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-02 19:31 [PATCH v3 00/18] introduce the Xen PV Calls backend Stefano Stabellini
2017-06-02 19:31 ` [PATCH v3 01/18] xen: introduce the pvcalls interface header Stefano Stabellini
2017-06-02 19:31   ` [PATCH v3 02/18] xen/pvcalls: introduce the pvcalls xenbus backend Stefano Stabellini
2017-06-02 19:31   ` [PATCH v3 03/18] xen/pvcalls: initialize the module and register the " Stefano Stabellini
2017-06-02 19:31   ` [PATCH v3 04/18] xen/pvcalls: xenbus state handling Stefano Stabellini
2017-06-12 21:19     ` Boris Ostrovsky
2017-06-02 19:31   ` [PATCH v3 05/18] xen/pvcalls: connect to a frontend Stefano Stabellini
2017-06-12 21:27     ` Boris Ostrovsky
2017-06-02 19:31   ` [PATCH v3 06/18] xen/pvcalls: handle commands from the frontend Stefano Stabellini
2017-06-12 22:03     ` Boris Ostrovsky
2017-06-14 21:03       ` Stefano Stabellini
2017-06-15 14:33         ` Boris Ostrovsky
2017-06-15 18:54           ` Stefano Stabellini
2017-06-02 19:31   ` [PATCH v3 07/18] xen/pvcalls: implement socket command Stefano Stabellini
2017-06-13  6:06     ` Juergen Gross
2017-06-14  0:46       ` Stefano Stabellini
2017-06-02 19:31   ` [PATCH v3 08/18] xen/pvcalls: implement connect command Stefano Stabellini
2017-06-13  6:17     ` Juergen Gross
2017-06-14  0:46       ` Stefano Stabellini
2017-06-02 19:31   ` [PATCH v3 09/18] xen/pvcalls: implement bind command Stefano Stabellini
2017-06-13  7:00     ` Juergen Gross
2017-06-14  0:46       ` Stefano Stabellini
2017-06-02 19:31   ` [PATCH v3 10/18] xen/pvcalls: implement listen command Stefano Stabellini
2017-06-13  7:00     ` Juergen Gross
2017-06-02 19:31   ` [PATCH v3 11/18] xen/pvcalls: implement accept command Stefano Stabellini
2017-06-13  7:24     ` Juergen Gross
2017-06-14  0:47       ` Stefano Stabellini
2017-06-14  6:32         ` Juergen Gross
2017-06-14 19:27           ` Stefano Stabellini
2017-06-15  6:58             ` Juergen Gross
2017-06-15 17:54               ` Stefano Stabellini
2017-06-02 19:31   ` [PATCH v3 12/18] xen/pvcalls: implement poll command Stefano Stabellini
2017-06-13  7:28     ` Juergen Gross
2017-06-14  0:47       ` Stefano Stabellini
2017-06-02 19:31   ` [PATCH v3 13/18] xen/pvcalls: implement release command Stefano Stabellini
2017-06-13  7:39     ` Juergen Gross
2017-06-14  0:47       ` Stefano Stabellini
2017-06-02 19:31   ` [PATCH v3 14/18] xen/pvcalls: disconnect and module_exit Stefano Stabellini
2017-06-13  7:49     ` Juergen Gross
2017-06-14  0:54       ` Stefano Stabellini
2017-06-14 13:51         ` Boris Ostrovsky
2017-06-14 19:15           ` Stefano Stabellini
2017-06-02 19:31   ` [PATCH v3 15/18] xen/pvcalls: implement the ioworker functions Stefano Stabellini
2017-06-13  7:51     ` Juergen Gross
2017-06-14  0:56       ` Stefano Stabellini
2017-06-02 19:31   ` [PATCH v3 16/18] xen/pvcalls: implement read Stefano Stabellini
2017-06-13  7:56     ` Juergen Gross
2017-06-14  0:57       ` Stefano Stabellini
2017-06-02 19:31   ` Stefano Stabellini [this message]
2017-06-13  7:59     ` [PATCH v3 17/18] xen/pvcalls: implement write Juergen Gross
2017-06-14  1:00       ` Stefano Stabellini
2017-06-02 19:31   ` [PATCH v3 18/18] xen: introduce a Kconfig option to enable the pvcalls backend Stefano Stabellini
2017-06-13  6:02     ` Juergen Gross
2017-06-13 23:46       ` Stefano Stabellini
2017-06-12 21:17   ` [PATCH v3 01/18] xen: introduce the pvcalls interface header Boris Ostrovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1496431915-20774-17-git-send-email-sstabellini@kernel.org \
    --to=sstabellini@kernel.org \
    --cc=boris.ostrovsky@oracle.com \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stefano@aporeto.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).