From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751218AbdFEPmk convert rfc822-to-8bit (ORCPT <rfc822;w@1wt.eu>);
        Mon, 5 Jun 2017 11:42:40 -0400
Received: from mout.gmx.net ([212.227.15.15]:58480 "EHLO mout.gmx.net"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751077AbdFEPmj (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 5 Jun 2017 11:42:39 -0400
Message-ID: <1496677312.10610.21.camel@gmx.de>
Subject: Re: [bisected] Re: tty lockdep trace
From: Mike Galbraith <efault@gmx.de>
To: Alan Cox <gnomes@lxorguk.ukuu.org.uk>
Cc: Vegard Nossum <vegard.nossum@oracle.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Dave Jones <davej@codemonkey.org.uk>,
        Linux Kernel <linux-kernel@vger.kernel.org>,
        Jiri Slaby <jslaby@suse.com>
Date: Mon, 05 Jun 2017 17:41:52 +0200
In-Reply-To: <20170605160912.56c76d68@lxorguk.ukuu.org.uk>
References: <20170531172117.nj5fwgqspibg7rs6@codemonkey.org.uk>
         <1496471632.11868.1.camel@gmx.de> <20170604083225.GA2959@kroah.com>
         <1496566972.16375.10.camel@gmx.de>
         <6b025884-8fbc-1ae2-3119-63e601453ad6@oracle.com>
         <1496576071.6573.13.camel@gmx.de>
         <20170605160912.56c76d68@lxorguk.ukuu.org.uk>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.20.5 
Mime-Version: 1.0
Content-Transfer-Encoding: 8BIT
X-Provags-ID: V03:K0:pO522/ekYn2Xs0GvI8/EGNPuToX57KDLXdGP4cdRiXfjInR/Hk8
 1v0U4jrEyTZpK+UcfoJgOBTIWoJwanG2hl0bTt8IqLPdVT9Ih9f6Uyh80fpAu6yJ9W+WeMI
 e26dL0qzX6uVMjTg2fUG7v/7cbhATJ4KI7JsomyVFfgRaqh2rUbZck+16bAyxWOfL6GDYSx
 HKzuw1UNOHli17WNhZMqw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:HVn+b0ttOVY=:+zoRwkvgLkVjjctEeqAmCF
 p45AqRNxE591fjZibCcu2EMSokk84ciOWop4r/bbZFhlMD2CRsRiRWXLa0YqK37sjozs8mNFU
 9pvI/OtKcv7Oyhbrr0lNGMcEbVgP+dgNsWmVAq155WzYI6njpsbTueipwM/5Gd1cYUptHOQLI
 AeC8Tfd7pbAURdBfQDfMnUmeRUlGmVQPIA7e02Fr163aJKHM5eSHgmErJSNIqRzlXizuK+PCS
 JMgunyIi0O73CmciWfsG0G+mw5xkOvpm702M4YQh53yhphNIHuvN06LVQQldufdmBfRa5hVoC
 LH60FucIh5WKQpZ4pl5HlQ8pD3jopmxhBA1UoX/qYcQs+tKhQH3a7aYniJTxbJXbbIlIIW9nZ
 e8ZTmCFwR9oC8Vg0QKkreO+ho3ZhuxklxImlBvp7QBuA13XexE3oUw6wsKjCm+BEdp4v5Xc4s
 PuEE51s1ST5n195qOu0ULxRXXHZuyyfh4e1V2T/w2ZVmFcAt969dV25hgg4qQQsDeqoulwYv8
 UlVYkIAdFOek5onedhOEV6uzyBO7MthWmwOQ0S+3Wm6qaKCtXpwUckunZbErrX/F48sE4rAIw
 SfTg+aXoyWMRl5exeVddprB+qcniBmV+K1DS4HI+f7SnraTSpuwRxaXZqAyK/D4pL0i1DHwgW
 sR2MvHTB2W7eGby5inLgMswcQKHMlKf/gI936b+LLLIlF3zs2FRcp69sh5a2TM2ylqSn/A5Zs
 ahosjJU4pPsCILaiOAZamssUEaC+mV65KZXqe/XkCHIYGFRUaT+UCTIFc1o9UAtjHCEmgnsfH
 36ZKvEY
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 2017-06-05 at 16:09 +0100, Alan Cox wrote:
> On Sun, 04 Jun 2017 13:34:31 +0200
> Mike Galbraith <efault@gmx.de> wrote:
> 
> > On Sun, 2017-06-04 at 12:00 +0200, Vegard Nossum wrote:
> > > 
> > > I don't know how you did it, but this passes my testing (reproducers for
> > > both the original issue and the lockdep splat/hang).  
> > 
> > I suppose I can sign it off, see if that inspires anyone to come up
> > with something better.
> > 
> > drivers/tty: Fix 925bb1ce47f4 circular locking dependency
> 
> This is still completely broken and has the same underlying flaw as the
> original.

Thanks for looking.  It didn't look the least bit lovely, it being
equally busted (well, ever so slightly less, lockdep did sthu;) is not
a shocker.  Off to the bin ya go little patchlet.

	-Mike