From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751635AbdFEQTC (ORCPT ); Mon, 5 Jun 2017 12:19:02 -0400 Received: from mga03.intel.com ([134.134.136.65]:11323 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751614AbdFEQS7 (ORCPT ); Mon, 5 Jun 2017 12:18:59 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,302,1493708400"; d="scan'208";a="864756004" Message-ID: <1496679529.22624.14.camel@linux.intel.com> Subject: Re: [PATCH v2 1/5] acpi, nfit: Switch to use new generic UUID API From: Andy Shevchenko To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, "Rafael J . Wysocki" , linux-acpi@vger.kernel.org, Dan Williams , Mika Westerberg , Borislav Petkov , intel-gfx@lists.freedesktop.org Date: Mon, 05 Jun 2017 19:18:49 +0300 In-Reply-To: <20170605160102.GA29981@lst.de> References: <20170531194152.65927-1-andriy.shevchenko@linux.intel.com> <20170531194152.65927-2-andriy.shevchenko@linux.intel.com> <20170605160102.GA29981@lst.de> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2017-06-05 at 18:01 +0200, Christoph Hellwig wrote: > >   for (i = 0; i < NFIT_UUID_MAX; i++) > > - if (memcmp(to_nfit_uuid(i), spa->range_guid, 16) == > > 0) > > + if (!guid_equal(to_nfit_uuid(i), (guid_t *)&spa- > > >range_guid)) > >   return i; > > I think this should be guid_equal without the "!" Right. -- Andy Shevchenko Intel Finland Oy