From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752118AbdFER2b (ORCPT ); Mon, 5 Jun 2017 13:28:31 -0400 Received: from mga01.intel.com ([192.55.52.88]:21162 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751905AbdFEQUL (ORCPT ); Mon, 5 Jun 2017 12:20:11 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,302,1493708400"; d="scan'208";a="976974680" Message-ID: <1496679583.22624.15.camel@linux.intel.com> Subject: Re: [PATCH v2 2/5] ACPI / APEI: Switch to use new generic UUID API From: Andy Shevchenko To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, "Rafael J . Wysocki" , linux-acpi@vger.kernel.org, Dan Williams , Mika Westerberg , Borislav Petkov , intel-gfx@lists.freedesktop.org Date: Mon, 05 Jun 2017 19:19:43 +0300 In-Reply-To: <20170605160151.GB29981@lst.de> References: <20170531194152.65927-1-andriy.shevchenko@linux.intel.com> <20170531194152.65927-3-andriy.shevchenko@linux.intel.com> <20170605160151.GB29981@lst.de> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2017-06-05 at 18:01 +0200, Christoph Hellwig wrote: > > - if (!uuid_le_cmp(*(uuid_le *)gdata->section_type, > > -  CPER_SEC_PLATFORM_MEM)) { > > + if (!guid_equal(sec_type, &CPER_SEC_PLATFORM_MEM)) > > { > > The "!" here seems incorrect. > > >  #ifdef CONFIG_ACPI_APEI_PCIEAER > > - else if (!uuid_le_cmp(*(uuid_le *)gdata- > > >section_type, > > -       CPER_SEC_PCIE)) { > > + else if (!guid_equal(sec_type, &CPER_SEC_PCIE)) { > > Same here. Thanks! Are you going to fixup when applying or better me to send an updated version? -- Andy Shevchenko Intel Finland Oy