From: Joe Perches <joe@perches.com>
To: John Brooks <john@fastquake.com>, Andy Whitcroft <apw@canonical.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: Change format of --color argument to --color[=WHEN]
Date: Mon, 05 Jun 2017 16:10:30 -0700 [thread overview]
Message-ID: <1496704230.1968.5.camel@perches.com> (raw)
In-Reply-To: <1496701622-1465-1-git-send-email-john@fastquake.com>
On Mon, 2017-06-05 at 18:27 -0400, John Brooks wrote:
> The boolean --color argument did not offer the ability to force colourized
> output even if stdout is not a terminal.
OK, but why is colorizing output not to terminals desired?
> Change the format of the argument
> to the familiar --color[=WHEN] construct as seen in common Linux utilities
> such as ls and dmesg, which allows the user to specify whether to colourize
> output always, never, or only when the output is a terminal ("auto").
>
> Because the option is no longer boolean, --nocolor (or --no-color) is no
> longer available. Users of the old negative option should use --color=never
> instead.
In general, I don't mind, but perhaps this option name
could/should change.
As is, this also causes a previous command line that worked
with --color to fail
$ ./scripts/checkpatch.pl --color foo.patch
Invalid color mode: foo.patch
next prev parent reply other threads:[~2017-06-05 23:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-05 22:27 [PATCH] checkpatch: Change format of --color argument to --color[=WHEN] John Brooks
2017-06-05 23:10 ` Joe Perches [this message]
2017-06-05 23:28 ` John Brooks
2017-06-06 5:48 ` Adam Borowski
2017-06-06 17:07 ` [PATCH v2] " John Brooks
2017-06-06 19:21 ` Joe Perches
2017-06-06 19:56 ` John Brooks
2017-06-06 20:03 ` Joe Perches
2017-06-07 1:50 ` [PATCH V3] " Joe Perches
2017-06-07 13:41 ` John Brooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1496704230.1968.5.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=john@fastquake.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox