From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751323AbdFEXKe (ORCPT ); Mon, 5 Jun 2017 19:10:34 -0400 Received: from smtprelay0158.hostedemail.com ([216.40.44.158]:48758 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751274AbdFEXKd (ORCPT ); Mon, 5 Jun 2017 19:10:33 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::,RULES_HIT:41:355:379:541:599:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3874:4321:5007:6119:7903:10004:10400:10848:11232:11658:11914:12679:12740:12760:12895:13069:13311:13357:13439:14181:14659:14721:14819:21080:21627,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: game89_21c3056e4c927 X-Filterd-Recvd-Size: 1705 Message-ID: <1496704230.1968.5.camel@perches.com> Subject: Re: [PATCH] checkpatch: Change format of --color argument to --color[=WHEN] From: Joe Perches To: John Brooks , Andy Whitcroft Cc: linux-kernel@vger.kernel.org Date: Mon, 05 Jun 2017 16:10:30 -0700 In-Reply-To: <1496701622-1465-1-git-send-email-john@fastquake.com> References: <1496701622-1465-1-git-send-email-john@fastquake.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2017-06-05 at 18:27 -0400, John Brooks wrote: > The boolean --color argument did not offer the ability to force colourized > output even if stdout is not a terminal. OK, but why is colorizing output not to terminals desired? > Change the format of the argument > to the familiar --color[=WHEN] construct as seen in common Linux utilities > such as ls and dmesg, which allows the user to specify whether to colourize > output always, never, or only when the output is a terminal ("auto"). > > Because the option is no longer boolean, --nocolor (or --no-color) is no > longer available. Users of the old negative option should use --color=never > instead. In general, I don't mind, but perhaps this option name could/should change. As is, this also causes a previous command line that worked with --color to fail $ ./scripts/checkpatch.pl --color foo.patch Invalid color mode: foo.patch