From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751494AbdFGJh6 (ORCPT ); Wed, 7 Jun 2017 05:37:58 -0400 Received: from mga05.intel.com ([192.55.52.43]:56010 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751403AbdFGJh4 (ORCPT ); Wed, 7 Jun 2017 05:37:56 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,310,1493708400"; d="scan'208";a="96543496" Message-ID: <1496828271.22624.38.camel@linux.intel.com> Subject: Re: [PATCH v3 1/5] acpi, nfit: Switch to use new generic UUID API From: Andy Shevchenko To: "Williams, Dan J" , "hch@lst.de" Cc: "mika.westerberg@linux.intel.com" , "linux-kernel@vger.kernel.org" , "intel-gfx@lists.freedesktop.org" , "bp@suse.de" , "rjw@rjwysocki.net" , "linux-acpi@vger.kernel.org" Date: Wed, 07 Jun 2017 12:37:51 +0300 In-Reply-To: <1496816744.6978.6.camel@intel.com> References: <20170605164046.82676-1-andriy.shevchenko@linux.intel.com> <20170605164046.82676-2-andriy.shevchenko@linux.intel.com> <1496682642.22624.23.camel@linux.intel.com> <20170605212250.GA3772@lst.de> <1496816744.6978.6.camel@intel.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-06-07 at 06:25 +0000, Williams, Dan J wrote: > On Mon, 2017-06-05 at 23:22 +0200, Christoph Hellwig wrote: > > On Mon, Jun 05, 2017 at 08:10:42PM +0300, Andy Shevchenko wrote: > > > > > > I hope Christoph can replace old version of this series with new > > > one in > > > his uuid branch. URL in cover letter, repeating for your > > > convenience: > > > > > > [1]: git://git.infradead.org/users/hch/uuid.git > > > > Yeah, but I had to drop it again after noticing the guid_equals > > bits, > > and after not fixing up the GUID -> GUID_INIT rename. > > > > for-next in the above repo should have the proper base now, and acpi > > has the ACPI bits for Dan to test. > > With one compile fix below the 'acpi' branch works for me. Please feel > free to add: > > Tested-by: Dan Williams Thanks, Dan! I probably missed some configuration option since I have done compilation many times. > > ...to the changes that touch drivers/acpi/nfit/, drivers/nvdimm/, and > tools/testing/nvdimm, but I'm ok if you omit it if the branch is about > to go immutable. Speaking of which, let me know when it does go > immutable because the new libnvdimm enabling for ACPI 6.2 and EFI 2.7 > needs some new guid handling code. > > Please apply the following or fold it into commit c793ed7ccf42 "ACPI: > Switch to use generic guid_t in acpi_evaluate_dsm()" It think we may fold it. Besides that we might need the following fix as well. --- a/drivers/acpi/utils.c +++ b/drivers/acpi/utils.c @@ -638,7 +638,7 @@ acpi_evaluate_dsm(acpi_handle handle, const guid_t *guid, u64 rev, u64 func,     params[0].type = ACPI_TYPE_BUFFER;   params[0].buffer.length = 16; - params[0].buffer.pointer = (u8 *)&guid; + params[0].buffer.pointer = (u8 *)guid;   params[1].type = ACPI_TYPE_INTEGER; params[1].integer.value = rev; params[2].type = ACPI_TYPE_INTEGER; -- Andy Shevchenko Intel Finland Oy