public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "jslaby@suse.com" <jslaby@suse.com>,
	"andreyknvl@google.com" <andreyknvl@google.com>,
	"kcc@google.com" <kcc@google.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"dvyukov@google.com" <dvyukov@google.com>,
	"syzkaller@googlegroups.com" <syzkaller@googlegroups.com>
Subject: Re: tty: possible deadlock in tty_buffer_flush
Date: Wed, 7 Jun 2017 17:39:30 +0000	[thread overview]
Message-ID: <1496857168.2779.0.camel@sandisk.com> (raw)
In-Reply-To: <20170607085010.GB13755@kroah.com>

On Wed, 2017-06-07 at 10:50 +0200, gregkh@linuxfoundation.org wrote:
> On Wed, Jun 07, 2017 at 12:42:12AM +0000, Bart Van Assche wrote:
> > On Mon, 2017-05-29 at 17:19 +0200, Andrey Konovalov wrote:
> > > I've got the following error report while fuzzing the kernel with syzkaller.
> > > 
> > > On commit 5ed02dbb497422bf225783f46e6eadd237d23d6b (4.12-rc3).
> > > 
> > > ======================================================
> > > WARNING: possible circular locking dependency detected
> > > 4.12.0-rc3+ #369 Not tainted
> > > ------------------------------------------------------
> > > kworker/u9:1/31 is trying to acquire lock:
> > >  (&buf->lock){+.+...}, at: [<ffffffff823dd42b>]
> > > tty_buffer_flush+0xbb/0x3b0 drivers/tty/tty_buffer.c:221
> > > 
> > > but task is already holding lock:
> > >  (&o_tty->termios_rwsem/1){++++..}, at: [<ffffffff823cd5d1>]
> > > isig+0xa1/0x4d0 drivers/tty/n_tty.c:1100
> > > 
> > > which lock already depends on the new lock.
> > 
> > Hello Andrey,
> > 
> > I also see this warning but during regular boot (without running syzkaller).
> > Do you perhaps have the time to bisect this?
> 
> Should be fixed in 4.12-rc4, right?

That's right.

Thanks!

Bart.

      reply	other threads:[~2017-06-07 17:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-29 15:19 tty: possible deadlock in tty_buffer_flush Andrey Konovalov
2017-06-07  0:42 ` Bart Van Assche
2017-06-07  8:50   ` gregkh
2017-06-07 17:39     ` Bart Van Assche [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1496857168.2779.0.camel@sandisk.com \
    --to=bart.vanassche@sandisk.com \
    --cc=andreyknvl@google.com \
    --cc=dvyukov@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=kcc@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=syzkaller@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox