From: Joe Perches <joe@perches.com>
To: Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Pali Rohár" <pali.rohar@gmail.com>,
"Andy Shevchenko" <andy@infradead.org>,
"Andy Lutomirski" <luto@kernel.org>,
"Platform Driver" <platform-driver-x86@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform/x86: wmi: Fix printing info about WDG structure
Date: Thu, 08 Jun 2017 08:38:07 -0700 [thread overview]
Message-ID: <1496936287.1929.18.camel@perches.com> (raw)
In-Reply-To: <20170608151618.GE32509@fury>
On Thu, 2017-06-08 at 08:16 -0700, Darren Hart wrote:
> On Sat, May 27, 2017 at 11:49:22PM +0300, Andy Shevchenko wrote:
> > On Sat, May 27, 2017 at 11:48 PM, Pali Rohár <pali.rohar@gmail.com> wrote:
> > > On Saturday 27 May 2017 15:33:14 Andy Shevchenko wrote:
> > > > On Sat, May 27, 2017 at 4:17 PM, Pali Rohár <pali.rohar@gmail.com>
> > > > wrote:
> > > > Okay, got it. But on your opinion does it make sense to do
> > > >
> > > > pr_info("\tobject_id: %2pE\n", g->object_id);
> > > >
> > > > instead?
> > > >
> > > > For ASCII it will go as is previously, otherwise escaping would be
> > > > done.
> > >
> > > Both is OK for me. Do you want to send a new patch with %2pE?
> >
> > To me it looks slightly cleaner.
>
> I don't want to let this one fall through the cracks. Pali, is a new one coming?
Perhaps
pr_info("\t%*pE\n", (int)sizeof(g->object_id), g->object_id);
next prev parent reply other threads:[~2017-06-08 15:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-27 11:51 [PATCH] platform/x86: wmi: Fix printing info about WDG structure Pali Rohár
2017-05-27 13:07 ` Andy Shevchenko
2017-05-27 13:17 ` Pali Rohár
2017-05-27 13:23 ` Pali Rohár
2017-05-27 13:33 ` Andy Shevchenko
2017-05-27 20:48 ` Pali Rohár
2017-05-27 20:49 ` Andy Shevchenko
2017-06-08 15:16 ` Darren Hart
2017-06-08 15:38 ` Joe Perches [this message]
2017-06-08 17:42 ` Andy Shevchenko
2017-06-08 17:44 ` Andy Shevchenko
2017-06-08 18:18 ` Pali Rohár
2017-06-09 8:29 ` Pali Rohár
2017-06-09 9:29 ` Andy Shevchenko
2017-06-10 10:57 ` [PATCH v2] " Pali Rohár
2017-06-10 11:22 ` Andy Shevchenko
2017-06-13 16:52 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1496936287.1929.18.camel@perches.com \
--to=joe@perches.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=pali.rohar@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox