From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751835AbdFILmu (ORCPT ); Fri, 9 Jun 2017 07:42:50 -0400 Received: from mail-wr0-f177.google.com ([209.85.128.177]:33146 "EHLO mail-wr0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751571AbdFILls (ORCPT ); Fri, 9 Jun 2017 07:41:48 -0400 From: Bartosz Golaszewski To: Andy Shevchenko , Linus Walleij , Alexandre Courbot , Bamvor Jian Zhang Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH v3 6/8] gpio: mockup: improve the error message Date: Fri, 9 Jun 2017 13:41:30 +0200 Message-Id: <1497008492-14907-7-git-send-email-brgl@bgdev.pl> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1497008492-14907-1-git-send-email-brgl@bgdev.pl> References: <1497008492-14907-1-git-send-email-brgl@bgdev.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Indicate the error number and make the message a bit more elaborate. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-mockup.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c index ab2d38e..2f4fe41 100644 --- a/drivers/gpio/gpio-mockup.c +++ b/drivers/gpio/gpio-mockup.c @@ -373,8 +373,9 @@ static int gpio_mockup_probe(struct platform_device *pdev) } if (ret) { - dev_err(dev, "gpio<%d..%d> add failed\n", - base, base < 0 ? ngpio : base + ngpio); + dev_err(dev, + "adding gpiochip failed: %d (base: %d, ngpio: %d)\n", + ret, base, base < 0 ? ngpio : base + ngpio); return ret; } -- 2.9.3