public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Toshi Kani <toshi.kani@hp.com>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	srivatsa.bhat@linux.vnet.ibm.com, isimatu.yasuaki@jp.fujitsu.com
Subject: Re: [PATCH 0/2] Protect cpu map updates from ACPI processor
Date: Tue, 13 Aug 2013 13:47:49 +0200	[thread overview]
Message-ID: <1497141.gLtk1PtyFs@vostro.rjw.lan> (raw)
In-Reply-To: <1376355303.10300.376.camel@misato.fc.hp.com>

On Monday, August 12, 2013 06:55:03 PM Toshi Kani wrote:
> On Tue, 2013-08-13 at 02:43 +0200, Rafael J. Wysocki wrote:
> > On Monday, August 12, 2013 09:45:52 AM Toshi Kani wrote:
> > > CPU system maps are protected with reader/writer locks.  The reader
> > > lock, put_online_cpus(), assures that the maps are not updated while
> > > holding the lock.  The writer lock, cpu_hotplug_begin(), is used to
> > > udpate the cpu maps along with cpu_maps_update_begin().
> > > 
> > > However, the ACPI processor handler updates the cpu maps without
> > > holding the the writer lock.  This patchset fixes this problem.
> > > 
> > > ---
> > > The patchset is based on linux-next of the pm tree.
> > 
> > Basically looks OK to me, but I'd just merge the patches together,
> > because the [2/2] is the very reason for the change made by [1/2].
> 
> I separated for reviewing purpose, but yes, they can be together.  Let
> me know if you need me to re-send it together.

I combined them and added a changelog built out of the messages you sent in
this thread.  Please check:

http://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git/commit/?h=bleeding-edge&id=b9d10be7a8e88fdcb12540387c219cdde87b0795

Thanks,
Rafael


  reply	other threads:[~2013-08-13 11:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-12 15:45 [PATCH 0/2] Protect cpu map updates from ACPI processor Toshi Kani
2013-08-12 15:45 ` [PATCH 1/2] CPU hotplug: Export cpu_hotplug_begin() interface Toshi Kani
2013-08-12 15:45 ` [PATCH 2/2] ACPI: Acquire writer lock to update cpu maps Toshi Kani
2013-08-13  0:43 ` [PATCH 0/2] Protect cpu map updates from ACPI processor Rafael J. Wysocki
2013-08-13  0:55   ` Toshi Kani
2013-08-13 11:47     ` Rafael J. Wysocki [this message]
2013-08-13 14:52       ` Toshi Kani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1497141.gLtk1PtyFs@vostro.rjw.lan \
    --to=rjw@sisk.pl \
    --cc=isimatu.yasuaki@jp.fujitsu.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=srivatsa.bhat@linux.vnet.ibm.com \
    --cc=toshi.kani@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox