From: Johannes Berg <johannes@sipsolutions.net>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>,
linux-kernel@vger.kernel.org,
kernel-hardening@lists.openwall.com
Cc: linux-wireless@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 6/6] mac80211/wpa: use constant time memory comparison for MACs
Date: Tue, 13 Jun 2017 10:20:00 +0200 [thread overview]
Message-ID: <1497342000.6068.3.camel@sipsolutions.net> (raw)
In-Reply-To: <20170610025912.6499-7-Jason@zx2c4.com>
On Sat, 2017-06-10 at 04:59 +0200, Jason A. Donenfeld wrote:
> Otherwise, we enable all sorts of forgeries via timing attack.
I'm not really sure that this is actually true, since you don't get
much feedback on your frame that's dropped, especially if you're
attacking from remote. Basically, I don't see how you can observe the
timing of this operation?
Anyway, applied.
johannes
next prev parent reply other threads:[~2017-06-13 8:20 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-10 2:59 [PATCH 0/6] Constant Time Memory Comparisons Are Important Jason A. Donenfeld
2017-06-10 2:59 ` [PATCH 1/6] sunrpc: use constant time memory comparison for mac Jason A. Donenfeld
2017-06-10 2:59 ` [PATCH 2/6] net/ipv6: " Jason A. Donenfeld
2017-06-10 2:59 ` [PATCH 3/6] ccree: use constant time memory comparison for macs and tags Jason A. Donenfeld
2017-06-10 7:43 ` Gilad Ben-Yossef
2017-06-10 10:54 ` Jason A. Donenfeld
2017-06-10 21:43 ` Henrique de Moraes Holschuh
2017-06-10 2:59 ` [PATCH 4/6] security/keys: use constant time memory comparison for macs Jason A. Donenfeld
2017-06-14 8:47 ` [kernel-hardening] " James Morris
2017-06-10 2:59 ` [PATCH 5/6] bluetooth/smp: use constant time memory comparison for secret values Jason A. Donenfeld
2017-06-10 13:49 ` Marcel Holtmann
2017-06-10 2:59 ` [PATCH 6/6] mac80211/wpa: use constant time memory comparison for MACs Jason A. Donenfeld
2017-06-13 8:20 ` Johannes Berg [this message]
2017-06-13 13:28 ` Jason A. Donenfeld
2017-06-11 8:13 ` [PATCH 0/6] Constant Time Memory Comparisons Are Important Kalle Valo
2017-06-11 13:36 ` Kees Cook
2017-06-11 20:48 ` Emmanuel Grumbach
2017-06-11 21:30 ` Emil Lenngren
2017-06-12 5:03 ` Emmanuel Grumbach
2017-06-12 7:33 ` Arend van Spriel
2017-06-11 21:06 ` Stephan Müller
2017-06-11 21:21 ` Jason A. Donenfeld
2017-06-11 21:20 ` [PATCH] rsa-pkcs1pad: use constant time memory comparison for MACs Jason A. Donenfeld
2017-06-20 3:38 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1497342000.6068.3.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Jason@zx2c4.com \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).