From: Joe Perches <joe@perches.com>
To: Steffen Maier <maier@linux.vnet.ibm.com>,
Andy Whitcroft <apw@canonical.com>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-s390@vger.kernel.org
Subject: Re: [PATCH v2] checkpatch: [HLP]LIST_HEAD is also declaration
Date: Wed, 14 Jun 2017 06:39:38 -0700 [thread overview]
Message-ID: <1497447578.18751.51.camel@perches.com> (raw)
In-Reply-To: <20170614133512.89425-1-maier@linux.vnet.ibm.com>
On Wed, 2017-06-14 at 15:35 +0200, Steffen Maier wrote:
> Fixes the following false warning
> among others for LLIST_HEAD and PLIST_HEAD:
>
> WARNING: Missing a blank line after declarations
> #71: FILE: drivers/s390/scsi/zfcp_fsf.c:422:
> + struct hlist_node *tmp;
> + HLIST_HEAD(remove_queue);
>
> Signed-off-by: Steffen Maier <maier@linux.vnet.ibm.com>
> ---
> Changes from v1:
> Extended it to also support LLIST_HEAD and PLIST_HEAD as suggested by
> Joe Perches.
Acked-by: Joe Perches <joe@perches.com>
> scripts/checkpatch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 4b9569fa931b..86818b0ba8be 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -732,7 +732,7 @@ our $FuncArg = qr{$Typecast{0,1}($LvalOrFunc|$Constant|$String)};
>
> our $declaration_macros = qr{(?x:
> (?:$Storage\s+)?(?:[A-Z_][A-Z0-9]*_){0,2}(?:DEFINE|DECLARE)(?:_[A-Z0-9]+){1,6}\s*\(|
> - (?:$Storage\s+)?LIST_HEAD\s*\(|
> + (?:$Storage\s+)?[HLP]?LIST_HEAD\s*\(|
> (?:$Storage\s+)?${Type}\s+uninitialized_var\s*\(
> )};
>
next prev parent reply other threads:[~2017-06-14 13:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 10:16 [PATCH] checkpatch: HLIST_HEAD is also declaration Steffen Maier
2017-06-14 10:41 ` Joe Perches
2017-06-14 10:45 ` Joe Perches
2017-06-14 13:35 ` [PATCH v2] checkpatch: [HLP]LIST_HEAD " Steffen Maier
2017-06-14 13:39 ` Joe Perches [this message]
2017-06-14 13:43 ` Steffen Maier
2017-06-14 13:49 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1497447578.18751.51.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=maier@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox