From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752908AbdFNSKc (ORCPT ); Wed, 14 Jun 2017 14:10:32 -0400 Received: from smtprelay0012.hostedemail.com ([216.40.44.12]:40706 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751920AbdFNSKb (ORCPT ); Wed, 14 Jun 2017 14:10:31 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:981:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:2198:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3351:3622:3865:3866:3867:3868:3870:3872:4250:4321:5007:10004:10400:10848:11026:11232:11473:11657:11658:11914:12043:12048:12296:12740:12760:12895:13069:13255:13311:13357:13439:14659:14721:21080:21451:21627,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:7,LUA_SUMMARY:none X-HE-Tag: tax06_7794cda1f1f02 X-Filterd-Recvd-Size: 1843 Message-ID: <1497463820.18751.57.camel@perches.com> Subject: Re: [PATCH 1/6] staging: lustre: lustre: resolve "use spaces between elements" checkpatch errors From: Joe Perches To: James Simmons , Greg Kroah-Hartman , devel@driverdev.osuosl.org, Andreas Dilger , Oleg Drokin Cc: Linux Kernel Mailing List , Lustre Development List Date: Wed, 14 Jun 2017 11:10:20 -0700 In-Reply-To: <1497452481-31124-2-git-send-email-jsimmons@infradead.org> References: <1497452481-31124-1-git-send-email-jsimmons@infradead.org> <1497452481-31124-2-git-send-email-jsimmons@infradead.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-06-14 at 11:01 -0400, James Simmons wrote: > Due to the way the DFID was embedded in our debug strings checkpatch > would report the following error: unrelated trivia > diff --git a/drivers/staging/lustre/lustre/include/lustre/lustre_user.h b/drivers/staging/lustre/lustre/include/lustre/lustre_user.h [] > @@ -532,7 +532,7 @@ static inline void obd_uuid2fsname(char *buf, char *uuid, int buflen) > #define FID_NOBRACE_LEN 40 > #define FID_LEN (FID_NOBRACE_LEN + 2) > #define DFID_NOBRACE "%#llx:0x%x:0x%x" It's odd to use a mixture of %#x and 0x%x. Using #define DFID_NOBRACE "%#llx:%#x:%#x" would also save a couple bytes per use. Does there need to be a difference between an SFID and a DFID_NOBRACE?