public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephane Eranian <eranian@google.com>
To: linux-kernel@vger.kernel.org
Cc: acme@redhat.com, peterz@infradead.org, mingo@elte.hu,
	ak@linux.intel.com, kan.liang@intel.com, jolsa@redhat.com
Subject: [PATCH 0/5] perf: add support for capturing skid IP
Date: Thu, 15 Jun 2017 06:56:24 -0700	[thread overview]
Message-ID: <1497534989-29231-1-git-send-email-eranian@google.com> (raw)

This patchs adds a new sample record type called
PERF_SAMPLE_SKID_IP. The goal is to record
the unmodified interrupted instruction pointer (IP) as seen by
the kernel and reflected in the machine state.

On some architectures, it is possible to avoid the IP skid using
hardware support. For instance, on Intel x86, the use of PEBS helps
eliminate the skid on Haswell and later processors. On older Intel
processor, software, i..e, the kernel,  may succeed in eliminating
the skid.

Without this patch, on Haswell processors, if you set:
 - attr.precise = 0, then you get the skid IP
 - attr.precise = 1, then you get the skid PEBS ip (off-by-1)
 - attr.precise = 2, then you get the skidless PEBS ip

The IP is captured when the event has PERF_SAMPLE_IP set in sample_type.
However, there are certain measurements where you need to have BOTH
the skidless IP and the skid IP. For instance, when studying branches,
the skid IP usually points to the target of the branch while the skidless
IP points to the branch instruction itself. Today, it is not possible to retrieve
both at the same time. This patch makes this possible by specifying
PERF_SAMPLE_IP|PERF_SAMPLE_SKID_IP.

As an example, consider the following code snipet:

 37.51 │42c2ed    je     42c2f3
       │42c2ef    add    $0x1,%rdx                                                                                                                                                                              ▒
       │42c2f3    sub    $0x1,%rax                                                                                                                                                                              ▒

When using PEBS (precise=2) and sampling on BR_INST_RETIRED.CONDITIONAL,
the IP always points to 0x42c2ed. With precise=1, the IP would point to
0x42c2f3. It is interesting to collect both IPs in a single run to determine
how often the conditional branch is taken vs. non-taken.

Stephane Eranian (5):
  perf/core: add PERF_SAMPLE_SKID_IP record type
  perf/x86: add PERF_SAMPLE_SKID_IP support for X86 PEBS
  perf/tools: add support for PERF_SAMPLE_SKID_IP
  perf/record: add support for sampling skid ip
  perf/script: add support for skid ip

 arch/x86/events/intel/ds.c               |  7 +++++++
 include/linux/perf_event.h               |  2 ++
 include/uapi/linux/perf_event.h          |  4 +++-
 kernel/events/core.c                     | 14 ++++++++++++++
 tools/include/uapi/linux/perf_event.h    |  4 +++-
 tools/perf/Documentation/perf-record.txt |  8 ++++++++
 tools/perf/builtin-record.c              |  2 ++
 tools/perf/builtin-script.c              | 12 +++++++++++-
 tools/perf/perf.h                        |  1 +
 tools/perf/util/event.h                  |  1 +
 tools/perf/util/evsel.c                  | 11 ++++++++++-
 tools/perf/util/session.c                |  3 +++
 12 files changed, 65 insertions(+), 4 deletions(-)

-- 
2.13.1.518.g3df882009-goog

             reply	other threads:[~2017-06-15 13:56 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-15 13:56 Stephane Eranian [this message]
2017-06-15 13:56 ` [PATCH 1/5] perf/core: add PERF_SAMPLE_SKID_IP record type Stephane Eranian
2017-06-15 13:56 ` [PATCH 2/5] perf/x86: add PERF_SAMPLE_SKID_IP support for X86 PEBS Stephane Eranian
2017-06-15 15:40   ` Liang, Kan
2017-06-15 16:39     ` Stephane Eranian
2017-06-15 17:18       ` Liang, Kan
2017-06-15 19:19       ` Stephane Eranian
2017-06-15 13:56 ` [PATCH 3/5] perf/tools: add support for PERF_SAMPLE_SKID_IP Stephane Eranian
2017-06-15 13:56 ` [PATCH 4/5] perf/record: add support for sampling skid ip Stephane Eranian
2017-06-15 13:56 ` [PATCH 5/5] perf/script: add support for " Stephane Eranian
2017-06-15 15:10 ` [PATCH 0/5] perf: add support for capturing skid IP Andi Kleen
2017-06-15 16:44   ` Stephane Eranian
2017-06-15 17:23     ` Andi Kleen
2017-06-15 19:35       ` Stephane Eranian
2017-06-15 20:02         ` Andi Kleen
2017-06-15 20:20           ` Stephane Eranian
2017-06-15 22:28             ` Stephane Eranian
2017-06-15 23:18               ` Andi Kleen
2017-06-16  6:52                 ` Stephane Eranian
2017-06-16 16:06                   ` Andi Kleen
2017-06-16 17:08                     ` Stephane Eranian
2017-06-16 17:12                       ` Stephane Eranian
2017-06-16 17:50                         ` Andi Kleen
2017-06-16 19:15                           ` Stephane Eranian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1497534989-29231-1-git-send-email-eranian@google.com \
    --to=eranian@google.com \
    --cc=acme@redhat.com \
    --cc=ak@linux.intel.com \
    --cc=jolsa@redhat.com \
    --cc=kan.liang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox