Re: [PATCH 0/5] perf: add support for capturing skid IP

Andi Kleen
2017-06-15T17:23:23Z

On Thu, Jun 15, 2017 at 09:44:07AM -0700, Stephane Eranian wrote:
> On Thu, Jun 15, 2017 at 8:10 AM, Andi Kleen <ak@linux.intel.com> wrote:
> > On Thu, Jun 15, 2017 at 06:56:24AM -0700, Stephane Eranian wrote:
> >> This patchs adds a new sample record type called
> >> PERF_SAMPLE_SKID_IP. The goal is to record
> >> the unmodified interrupted instruction pointer (IP) as seen by
> >> the kernel and reflected in the machine state.
> >
> > Patches look reasonable for me.
> >
> > If you only cared about branches it would be more natural to model
> > it like a 1 entry LBR. That would make a lot more tooling work
> > automatically.
> >
> You'd still have to modify tooling to present correct column headers.

Why? It's from/to?

-Andi