public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephane Eranian <eranian@google.com>
To: linux-kernel@vger.kernel.org
Cc: acme@redhat.com, peterz@infradead.org, mingo@elte.hu,
	ak@linux.intel.com, kan.liang@intel.com, jolsa@redhat.com
Subject: [PATCH 4/5] perf/record: add support for sampling skid ip
Date: Thu, 15 Jun 2017 06:56:28 -0700	[thread overview]
Message-ID: <1497534989-29231-5-git-send-email-eranian@google.com> (raw)
In-Reply-To: <1497534989-29231-1-git-send-email-eranian@google.com>

This patch adds a new --skid-ip option to perf record
to capture the unmodified interrupted instruction pointer in
each sample. With this option, the perf tool can request that
the kernel records both the ip and skid IP in each sample.
Unless precise mode is enabled both IPis are the same. They may be
different in precise mode depending on the event. 

$ perf record --skid-ip .....

Signed-off-by: Stephane Eranian <eranian@google.com>
---
 tools/perf/Documentation/perf-record.txt | 8 ++++++++
 tools/perf/builtin-record.c              | 2 ++
 2 files changed, 10 insertions(+)

diff --git a/tools/perf/Documentation/perf-record.txt b/tools/perf/Documentation/perf-record.txt
index b0e9e921d534..fa24376c20e0 100644
--- a/tools/perf/Documentation/perf-record.txt
+++ b/tools/perf/Documentation/perf-record.txt
@@ -477,6 +477,14 @@ config terms. For example: 'cycles/overwrite/' and 'instructions/no-overwrite/'.
 
 Implies --tail-synthesize.
 
+--skid-ip::
+Capture the unmodified interrupt instruction pointer (IP) in each sample. Usually
+with event-based sampling, the ip has skid and rarely points to the instruction which
+caused the event to overflow. On some architectures, the hardware can eliminate the
+skid and perf_events returns it as the IP when precise sampling is enabled. But for
+certain measurements, it may be useful to have both the corrected and skid ip. This
+option enables capturing the skid ip in addition to the corrected ip. Default: off
+
 SEE ALSO
 --------
 linkperf:perf-stat[1], linkperf:perf-list[1]
diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index ee7d0a82ccd0..66b497dc4333 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -1669,6 +1669,8 @@ static struct option __record_options[] = {
 			  "signal"),
 	OPT_BOOLEAN(0, "dry-run", &dry_run,
 		    "Parse options then exit"),
+	OPT_BOOLEAN(0, "skid-ip", &record.opts.skid_ip,
+		    "capture skid ip in addition to ip"),
 	OPT_END()
 };
 
-- 
2.13.1.518.g3df882009-goog

  parent reply	other threads:[~2017-06-15 13:56 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-15 13:56 [PATCH 0/5] perf: add support for capturing skid IP Stephane Eranian
2017-06-15 13:56 ` [PATCH 1/5] perf/core: add PERF_SAMPLE_SKID_IP record type Stephane Eranian
2017-06-15 13:56 ` [PATCH 2/5] perf/x86: add PERF_SAMPLE_SKID_IP support for X86 PEBS Stephane Eranian
2017-06-15 15:40   ` Liang, Kan
2017-06-15 16:39     ` Stephane Eranian
2017-06-15 17:18       ` Liang, Kan
2017-06-15 19:19       ` Stephane Eranian
2017-06-15 13:56 ` [PATCH 3/5] perf/tools: add support for PERF_SAMPLE_SKID_IP Stephane Eranian
2017-06-15 13:56 ` Stephane Eranian [this message]
2017-06-15 13:56 ` [PATCH 5/5] perf/script: add support for skid ip Stephane Eranian
2017-06-15 15:10 ` [PATCH 0/5] perf: add support for capturing skid IP Andi Kleen
2017-06-15 16:44   ` Stephane Eranian
2017-06-15 17:23     ` Andi Kleen
2017-06-15 19:35       ` Stephane Eranian
2017-06-15 20:02         ` Andi Kleen
2017-06-15 20:20           ` Stephane Eranian
2017-06-15 22:28             ` Stephane Eranian
2017-06-15 23:18               ` Andi Kleen
2017-06-16  6:52                 ` Stephane Eranian
2017-06-16 16:06                   ` Andi Kleen
2017-06-16 17:08                     ` Stephane Eranian
2017-06-16 17:12                       ` Stephane Eranian
2017-06-16 17:50                         ` Andi Kleen
2017-06-16 19:15                           ` Stephane Eranian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1497534989-29231-5-git-send-email-eranian@google.com \
    --to=eranian@google.com \
    --cc=acme@redhat.com \
    --cc=ak@linux.intel.com \
    --cc=jolsa@redhat.com \
    --cc=kan.liang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox