From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751680AbdFOQMT (ORCPT ); Thu, 15 Jun 2017 12:12:19 -0400 Received: from smtprelay0138.hostedemail.com ([216.40.44.138]:46282 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750749AbdFOQMS (ORCPT ); Thu, 15 Jun 2017 12:12:18 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:421:541:599:967:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2525:2560:2563:2682:2685:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3872:3873:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:5007:7903:9025:10004:10400:10848:11232:11658:11914:12043:12740:12760:12895:13069:13311:13357:13439:14096:14097:14181:14659:14721:21080:21627:30012:30054:30060:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: neck13_13b67c87c201a X-Filterd-Recvd-Size: 2089 Message-ID: <1497543134.14396.6.camel@perches.com> Subject: Re: [PATCH 5/6] staging: lustre: lustre: several over 80 characters cleanups From: Joe Perches To: James Simmons Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, Andreas Dilger , Oleg Drokin , Linux Kernel Mailing List , Lustre Development List Date: Thu, 15 Jun 2017 09:12:14 -0700 In-Reply-To: References: <1497452481-31124-1-git-send-email-jsimmons@infradead.org> <1497452481-31124-6-git-send-email-jsimmons@infradead.org> <1497464128.18751.59.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-06-15 at 17:06 +0100, James Simmons wrote: > > On Wed, 2017-06-14 at 11:01 -0400, James Simmons wrote: > > > Cleanup many of the over 80 characters reported by checkpatch > > > > Please don't let checkpatch get in the way of lustre > > readability. > > > > lustre commonly uses very long identifiers. > > Long identifiers and 80 columns don't mix well. > > > > It might be simpler to declare in some document that > > lustre uses lines of up to whatever length and require > > that checkpatch should be used with the --max-line-length > > option when run on lustre code. > > Greg would you be okay with this? I trust Greg isn't a zealot. Linus Torvalds has said he prefers a longer line length (up to 100 cols) https://lkml.org/lkml/2016/12/15/749 > If we changed to a max-line-length to > say 128 thay would mean very few checkpatch issues would remain.