Re: [PATCH 5/6] staging: lustre: lustre: several over 80 characters cleanups

Greg Kroah-Hartman
2017-06-23T20:25:45Z

On Thu, Jun 15, 2017 at 05:06:30PM +0100, James Simmons wrote:
>
> > On Wed, 2017-06-14 at 11:01 -0400, James Simmons wrote:
> > > Cleanup many of the over 80 characters reported by checkpatch
> >
> > Please don't let checkpatch get in the way of lustre
> > readability.
> >
> > lustre commonly uses very long identifiers.
> > Long identifiers and 80 columns don't mix well.
> >
> > It might be simpler to declare in some document that
> > lustre uses lines of up to whatever length and require
> > that checkpatch should be used with the --max-line-length
> > option when run on lustre code.
>
> Greg would you be okay with this? If we changed to a max-line-length to
> say 128 thay would mean very few checkpatch issues would remain.

No, I don't want you go change the max-line-length, just use your best
judgement. Some of the changes here in this very-big patch are just
fine, and should be done as they make the code easier to read.

Others, you are just having to fix pedantic things and there's no need
for that. Let me give you a few examples in this patch of what I'm
talking about to help you understand the difference...

thanks,

greg k-h