From: Joe Perches <joe@perches.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
Okash Khawaja <okash.khawaja@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
Samuel Thibault <samuel.thibault@ens-lyon.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
William Hubbs <w.d.hubbs@gmail.com>,
Chris Brannon <chris@the-brannons.com>,
Kirk Reiser <kirk@reisers.ca>,
speakup@linux-speakup.org, devel@driverdev.osuosl.org
Subject: Re: [patch v2 2/3] staging: speakup: check and convert dev name or ser to dev_t
Date: Sun, 18 Jun 2017 17:37:50 -0700 [thread overview]
Message-ID: <1497832670.8495.33.camel@perches.com> (raw)
In-Reply-To: <CAHp75VeSjCB8CSS_RqKMGB0+zqRZbQqtajS-ebhQv4HKA-V4JA@mail.gmail.com>
On Sun, 2017-06-18 at 22:54 +0300, Andy Shevchenko wrote:
> On Sun, Jun 18, 2017 at 8:22 PM, Okash Khawaja <okash.khawaja@gmail.com> wrote:
> > On Sun, Jun 18, 2017 at 04:35:21PM +0300, Andy Shevchenko wrote:
> > > > + if (ser < 0 || ser > (255 - 64)) {
> > > > + pr_err("speakup: Invalid ser param. \
> > > > + Must be between 0 and 191 inclusive.\n");
> > >
> > > Just make it one line.
> >
> > Is it okay if it becomes larger than 80 chars?
>
> Yes. Even checkpatch will not complain in this case.
And even if it didn't, as written it's a defect
because line continuations don't act like
string concatenations. You've added a space
before the line continuation \ and a bunch of
whitespace before the word Must
next prev parent reply other threads:[~2017-06-19 0:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-18 8:58 [patch v2 0/3] staging: speakup: support more than ttyS* Okash Khawaja
2017-06-18 8:58 ` [patch v2 1/3] tty: add function to convert device name to number Okash Khawaja
2017-06-18 13:27 ` Andy Shevchenko
2017-06-19 8:09 ` Okash Khawaja
2017-06-18 8:58 ` [patch v2 2/3] staging: speakup: check and convert dev name or ser to dev_t Okash Khawaja
2017-06-18 13:35 ` Andy Shevchenko
2017-06-18 17:22 ` Okash Khawaja
2017-06-18 19:54 ` Andy Shevchenko
2017-06-19 0:37 ` Joe Perches [this message]
2017-06-19 1:15 ` Greg Kroah-Hartman
2017-06-19 5:33 ` Joe Perches
2017-06-19 5:38 ` Greg Kroah-Hartman
2017-06-19 5:39 ` Okash Khawaja
2017-06-19 8:27 ` Dan Carpenter
2017-06-18 8:58 ` [patch v2 3/3] staging: speakup: make ttyio synths use device name Okash Khawaja
2017-06-18 13:38 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1497832670.8495.33.camel@perches.com \
--to=joe@perches.com \
--cc=andy.shevchenko@gmail.com \
--cc=chris@the-brannons.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=okash.khawaja@gmail.com \
--cc=samuel.thibault@ens-lyon.org \
--cc=speakup@linux-speakup.org \
--cc=w.d.hubbs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).