From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753684AbdEDM7B (ORCPT ); Thu, 4 May 2017 08:59:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45584 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750934AbdEDM6x (ORCPT ); Thu, 4 May 2017 08:58:53 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 828FF80058 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=dhowells@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 828FF80058 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <87fugl3c22.fsf@rasmusvillemoes.dk> References: <87fugl3c22.fsf@rasmusvillemoes.dk> <149382747487.30481.15428192741961545429.stgit@warthog.procyon.org.uk> <149382750838.30481.8003919639826341255.stgit@warthog.procyon.org.uk> To: Rasmus Villemoes Cc: dhowells@redhat.com, viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, mszeredi@redhat.com Subject: Re: [PATCH 4/9] Implement fsopen() to prepare for a mount MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <14978.1493902730.1@warthog.procyon.org.uk> Date: Thu, 04 May 2017 13:58:50 +0100 Message-ID: <14979.1493902730@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Thu, 04 May 2017 12:58:52 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Rasmus Villemoes wrote: > > +const struct file_operations fs_fs_fops = { > > + .read = fs_fs_read, > > + .write = fs_fs_write, > > + .release = fs_fs_release, > > + .llseek = no_llseek, > > +}; > > + > > static const struct ? No. It's used in the next patch to validate the fd passed to sys_fsmount(): if (f.file->f_op != &fs_fs_fops) goto err_fsfd; David