Re: [PATCH v3 15/15] spi: qup: support for qup v1 dma

Andy Gross
2017-06-28T06:47:49Z

On Fri, Jun 23, 2017 at 04:49:23PM -0500, Rob Herring wrote:
> On Tue, Jun 20, 2017 at 02:40:57PM +0530, Varadarajan Narayanan wrote:
> > Currently the QUP Version v1 does not work with DMA so added
> > the support for the same.
> >
> > 1. It uses ADM DMA which requires TX and RX CRCI
> > 2. DMA channel initialization need to be done after setting
> > block size for having valid values in maxburst
> > 3. QUP mode should be DMOV instead of BAM.
> >
> > Signed-off-by: Abhishek Sahu <absahu@codeaurora.org>
> > Signed-off-by: Varadarajan Narayanan <varada@codeaurora.org>
> > ---
> > .../devicetree/bindings/spi/qcom,spi-qup.txt | 6 ++++
> > drivers/spi/spi-qup.c | 35 +++++++++++++++++-----
> > 2 files changed, 34 insertions(+), 7 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-qup.txt b/Documentation/devicetree/bindings/spi/qcom,spi-qup.txt
> > index 5c09077..e754181 100644
> > --- a/Documentation/devicetree/bindings/spi/qcom,spi-qup.txt
> > +++ b/Documentation/devicetree/bindings/spi/qcom,spi-qup.txt
> > @@ -38,6 +38,12 @@ Optional properties:
> > - dma-names: Names for the dma channels, if present. There must be at
> > least one channel named "tx" for transmit and named "rx" for
> > receive.
> > +- qcom,tx-crci: Identificator for Client Rate Control Interface (CRCI) to be
>
> Identificator is not a word.
>
> This sounds like something that should be a cell in the dmas property.

Yes, the CRCI should be part of the dma cells for the ADM. That would make a
channel + crci work as a virtual channel that is backed by a hardware channel.

The only thing that has to be dealt with is the protocol difference between the
BAM and ADM dma blocks, which is what the v1 compatible tells us.

Regards,
Andy